Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 2 Jul 2018 14:39:28 -0700
From:   Paul Burton <paul.burton@mips.com>
To:     Ralf Baechle <ralf@linux-mips.org>
Cc:     linux-mips@linux-mips.org, James Hogan <jhogan@kernel.org>,
        Julia Lawall <julia.lawall@lip6.fr>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Remove no-op cast in show_regs()
Message-ID: <20180702213928.35olwcekyg7shwow@pburton-laptop>
References: <20180622180703.18324-1-paul.burton@mips.com>
 <20180702152029.GA437552@linux-mips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180702152029.GA437552@linux-mips.org>
User-Agent: NeoMutt/20180622
Received-SPF: None (protection.outlook.com: wavecomp.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2018 21:39:31.1835 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e9fa3cb3-a114-4463-443b-08d5e0644ba7
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 463607d3-1db3-40a0-8a29-970c56230104
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR08MB4934
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ralf,

On Mon, Jul 02, 2018 at 05:20:29PM +0200, Ralf Baechle wrote:
> On Fri, Jun 22, 2018 at 11:07:03AM -0700, Paul Burton wrote:
> 
> > In show_regs() we have a regs argument of type struct pt_regs *, and we
> > explicitly cast it to that same type as part of calling __show_regs().
> > 
> > Casting regs to the same type that it is declared as does nothing at
> > all, so remove the useless cast.
> 
> Good catch but there's no dump_stack() in v4.18-rc3 so this doesn't apply.

dump_stack() is there in mips-fixes as part of fixing up
arch_trigger_cpumask_backtrace(), so this would apply once the next
fixes pull happens.

But I'm all for cleaning up other instances too.

Thanks,
    Paul