Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp450298imm; Mon, 2 Jul 2018 14:48:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcGU9BseZSWWKXbMm90DjPnHIa7YnSXaLS62qK6WgDKubQMPKEe3d8R7cfluu77hGUzrUaT X-Received: by 2002:a62:f50b:: with SMTP id n11-v6mr17005802pfh.120.1530568138024; Mon, 02 Jul 2018 14:48:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530568138; cv=none; d=google.com; s=arc-20160816; b=uH93ZFksk91U0fe6+XvEZlAb7xlv1kKtdfh9gOiNmb9Fhq3VViqnZYR3reGOjGf5Wb 4P316quOMgTQJj0MeAv/G12Pf/qYjUBmW6AMYTre7JeScKfiCuqifT1XhFPtemtPZRJM QULuAKVVVsfXKh9drU3vh7BU8eWsezE3Tef1EDF22d5/LYHAh/EGv9CuKZBk01elN+PC wbBvOlrSvmRlBvMuezRIosUO5q78QA7RK5qsw4TgFP2qz1vCiNOMiWBj322Lrg+xQCGi Ixs3Q4MLQ3VTEuPNd3WFe/ZqY1Y4uon+G4XP0bPcfMsrVx8RAgZBpZ0pMWOP+gB/RDki 7mMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=gwRD2Oxn9GqBIvs9gvCg5Mzju0e0I3Ojbls2iUc+3wc=; b=uK7jxt71kJJLpzmdCVDTtbwNa+5aT1tqPSSMIIN/k4UWEW+RCmmkR7ckW4uMWrbxCw earYLEX6QpC6fZR4WJZApqFXw+RzQlD5dWeW5Ru1lS1VjkbBn7aMLGOlh/ek22LyTJ3x lRGuxV7uLP9ejFoNxfeLtKI5xkFm+hQ8FW0cn/SXU/IdY/Db0a1cZ0MFLAmseURCbEys 5uQJ3TfR86ZDAS8zTKG1AuAWBeCRmqEVgCLH+CvMcCdtszJNQ+T5E22kTmRVNzxBhMO5 XBEUVs1x0Vv2PJY9LKFjUMkONIxe5WJamp0UJeioothictuivwn6yLOc/JLkBgRfNYmh nXzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=LFeBMLtO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p8-v6si16942010plk.441.2018.07.02.14.48.43; Mon, 02 Jul 2018 14:48:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=LFeBMLtO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753618AbeGBVrq (ORCPT + 99 others); Mon, 2 Jul 2018 17:47:46 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:51385 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbeGBVrp (ORCPT ); Mon, 2 Jul 2018 17:47:45 -0400 Received: by mail-it0-f51.google.com with SMTP id o5-v6so369405itc.1 for ; Mon, 02 Jul 2018 14:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gwRD2Oxn9GqBIvs9gvCg5Mzju0e0I3Ojbls2iUc+3wc=; b=LFeBMLtO8GMOhQtiYBolBJH2hVuiJtGwRFI4Xn4jW4nCLR85MsICb73evgZJYFPtEy QA8nSVcy3AlGC5iRXsmrOAAY9tvs7rZ6wjJ9QgKf4FcjRQUUtd02wiWW6fVOvfLuv92u 0fwZEA9q45CsmJ0+c8MQ6yi6eeOjdD8WssnCdpbBk0NTnJ1U16ZdzG+Y/8WkXLsleYOy qhYR7ZTgVuT34ysT+Pd+SiSPgMwWYlvi5SkX0HxrLyTx0eYt/QEMsY8Ec7N8Us/e18zA KfT88IdYCHQ6gfPX1gP1L/hvuYiePOf05lrLG4vX28DUyDq7rs4giW8V0g2YIsZFfgxq 3q4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gwRD2Oxn9GqBIvs9gvCg5Mzju0e0I3Ojbls2iUc+3wc=; b=QOvJYtahL05CMK+pTlLKyzqNJhwZGya+KZjBpC1iFd9ll92xMWe5BOkaYFk+qJNrFG lh2v3zjI7X1rueRfQ8V8f/8U52mpK1/bohxev2kTUW+lVrwFsG7Pv/Ovl4Utxdv2M0tl OLP/Ynp6a20hxIuP3SkWecXL5sMaQWuvFOGbw1VJ34/C4Dbh0oHCph2aKuCRC9ogLRL5 ISjsnagyyBcnVqHoh+Z7LdFInUnQeoW4ZBhBAaVbAq7JW+8SCXuIrrJ0/k8k0HxaC0bf 1stnRt2WpJCpYOPxafpNSdMEim7xEePv8N+ripUFJWsYBk9iRZ/7aMkooeLQZ+n5kGKk XSwg== X-Gm-Message-State: APt69E2pL0SDLWOakM4cbAHcscDIDbEoKEbhGTK1bRMOdtBcLtgLIwBt EOdAd0IFlP+ZySFaRdC2qPbfDUMCHT0= X-Received: by 2002:a02:4d57:: with SMTP id l84-v6mr22662948jab.56.1530568064765; Mon, 02 Jul 2018 14:47:44 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id k7-v6sm1679369ita.0.2018.07.02.14.47.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jul 2018 14:47:43 -0700 (PDT) Subject: Re: [PATCH 04/14] blk: introduce REQ_SWAP To: Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, tj@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Josef Bacik References: <20180629192542.26649-1-josef@toxicpanda.com> <20180629192542.26649-5-josef@toxicpanda.com> From: Jens Axboe Message-ID: <702d4535-5ea7-8704-b23c-91c44fda34a8@kernel.dk> Date: Mon, 2 Jul 2018 15:47:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180629192542.26649-5-josef@toxicpanda.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/18 1:25 PM, Josef Bacik wrote: > From: Josef Bacik > > Just like REQ_META, it's important to know the IO coming down is swap > in order to guard against potential IO priority inversion issues with > cgroups. Add REQ_SWAP and use it for all swap IO, and add it to our > bio_issue_as_root_blkg helper. We should convert wbt to use that as well. -- Jens Axboe