Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp487691imm; Mon, 2 Jul 2018 15:37:14 -0700 (PDT) X-Google-Smtp-Source: AAOMgpda03CBf+yv8TFRQiL/1fyWaPifuzYP7venyD5mjZNa3IGvMRAf/GxT9FGtONWlypE9/iyF X-Received: by 2002:a17:902:5381:: with SMTP id c1-v6mr22767570pli.137.1530571034184; Mon, 02 Jul 2018 15:37:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530571034; cv=none; d=google.com; s=arc-20160816; b=U+7LCZSNtB+9NyoNE/kmNoyWarySSGuDOIUxCvl07UK/Uy3Dr4TtYQfSjzgbPVT/zk ubIsZSg/NH63MPPNZp59Vrpemz5LVmSZNd/qWniIyTAQZNe4mTk2Dy6YBz/llRPDuR3P o2h094uUFuCqSum6FDUfFa+jJhpqZSDnszYjmq2OOpCP7grCNu5xBfIBGS1irRXlKgyt lShApk+W55tbhUAA5Pzp6fyBeoLq8wPvNrnnzN2y7ctkedNPnL/1gTtYuyWpOrA/+0rK 1N/D5HTBPidOUdM2dQ38AjTQMkxGTzf/vhOkQUQowNAVGENPEmp/WceP5L0Q8bJIzkeF DqgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=w1YajgAk0C3R/b2ymf2KDdl/bMnOd3CytM1D2clgIfo=; b=GiEG9XbLozwIUYmZx6wpaqqoxLtouE1VVgZr3fsk76laqSguwrOSv1fI6zdLeXhfXH pREVGZfI3DNp1l54Ss/jO6hHTEvvSly/sO13rMiFgm5dB6gbg6gdIFUoI4Br0rLnq+Zz rkeIh6W4oJT+uP2GPR1o8Td5MvPJd3dKSTUl0qHqbTZ9fmhdHjmJxNkt1Mh2F0nmwE3l Gfy4X8bVe/lIi2dK/kZlF/Jdc49U55kJs7mpzJD7VNoj0rHSm+Jo9LEouut8DKcrPRKz 2u6ew3n3Ub2hXlKp/djs/TkUYW8HbJicOQB3v0d7MX7HCapcRtia06n2n7HkXVq6AfIU voYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=i0MZIIOV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m37-v6si16925442plg.491.2018.07.02.15.37.00; Mon, 02 Jul 2018 15:37:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=i0MZIIOV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbeGBWgV (ORCPT + 99 others); Mon, 2 Jul 2018 18:36:21 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:54914 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932291AbeGBWgT (ORCPT ); Mon, 2 Jul 2018 18:36:19 -0400 Received: by mail-wm0-f68.google.com with SMTP id i139-v6so291930wmf.4; Mon, 02 Jul 2018 15:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w1YajgAk0C3R/b2ymf2KDdl/bMnOd3CytM1D2clgIfo=; b=i0MZIIOVSo/vCEShkYtD0StwukbZpFr8GHZ7PSdvzU6vWjDil82TPkajcSLcJn+ujc fMAcd7KNBXPeGFZ1Ygj+3Z/AWscwHB4phG86bbAt6FBmWtMVxmIib0h5ukyKUVhDhmhO Twd3EaIPntKSX2Ad7vb8YqLiTH4sVlVrPpyMxZ81R+MBHb475X2gGeB7m+tyLW7acF7a zgzp2fgxEB53w27FwAzXWrwJ9doCOICZtcoPOdt11fRVabiyeMqGrMaNYb8Jkp9MHYCT 5XAna6CiIuADsSkKXwWvkCO6DI3vNa+Hy0ErUnZu7VxZDjvpnqUpH9WDeGi6UuXw1QLn vpzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w1YajgAk0C3R/b2ymf2KDdl/bMnOd3CytM1D2clgIfo=; b=unMoVqG3LfaFDyrlE3fWJTa0cL8WzKKVUe4P/kny66mkDFz2m4yIyBdfNVO888Xg1c 5O8WV8hsjEb89DjudoMkraHTmhB26NqNKr0LChdf5SdRYgXltFtGfjrA1OH4nQA54O8/ UD4iyhrxOOC7wXYTo6X0McucfzMkavO7jRA2UL5l2wZQVJ7CZtY702VyVadpEHxe5gHf jVVe+syNmzfpuwYkZFu/vAXs11GECpjdyNMYqNHVo5zoI+zSNzBqhjpfgDR51D9EDpNH MtSXRJokB45GH/pP1y6P/c8lX5qoC4dwrpgj9YB6/EKhKfTgOztq3mIxN0tPDsvgbept PSyA== X-Gm-Message-State: APt69E3jRo+H+kNvaR3qLld3qFwmQesdNxhrnXzn1dtUThVmIPigmy5b vtS4mdO+xw28VZVSkqHLsAAK2BGaV2VY1k3aasXOx2bRNXY= X-Received: by 2002:a1c:5c82:: with SMTP id q124-v6mr9902370wmb.24.1530570978417; Mon, 02 Jul 2018 15:36:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:dcce:0:0:0:0:0 with HTTP; Mon, 2 Jul 2018 15:36:17 -0700 (PDT) In-Reply-To: <20180702214647.1574-1-erosca@de.adit-jv.com> References: <20180702214647.1574-1-erosca@de.adit-jv.com> From: Ruslan Bilovol Date: Tue, 3 Jul 2018 01:36:17 +0300 Message-ID: Subject: Re: [PATCH] usb: gadget: f_uac2: fix endianness of 'struct cntrl_*_lay3' To: Eugeniu Rosca Cc: Felipe Balbi , Felipe Balbi , Greg Kroah-Hartman , Vincent Pelletier , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Eugeniu Rosca , Eugeniu Rosca Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 3, 2018 at 12:46 AM, Eugeniu Rosca wrote: > The list [1] of commits doing endianness fixes in USB subsystem is long > due to below quote from USB spec Revision 2.0 from April 27, 2000: > > ------------ > 8.1 Byte/Bit Ordering > > Multiple byte fields in standard descriptors, requests, and responses > are interpreted as and moved over the bus in little-endian order, i.e. > LSB to MSB. > ------------ > > This commit belongs to the same family. > > [1] Example of endianness fixes in USB subsystem: > commit 14e1d56cbea6 ("usb: gadget: f_uac2: endianness fixes.") > commit 42370b821168 ("usb: gadget: f_uac1: endianness fixes.") > commit 63afd5cc7877 ("USB: chaoskey: fix Alea quirk on big-endian hosts") > commit 74098c4ac782 ("usb: gadget: acm: fix endianness in notifications") > commit cdd7928df0d2 ("ACM gadget: fix endianness in notifications") > commit 323ece54e076 ("cdc-wdm: fix endianness bug in debug statements") > commit e102609f1072 ("usb: gadget: uvc: Fix endianness mismatches") > list goes on > > Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver") > Signed-off-by: Eugeniu Rosca Good catch! Reviewed-by: Ruslan Bilovol > --- > drivers/usb/gadget/function/f_uac2.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c > index d2dc1f00180b..540a0ce63ad4 100644 > --- a/drivers/usb/gadget/function/f_uac2.c > +++ b/drivers/usb/gadget/function/f_uac2.c > @@ -438,14 +438,14 @@ static struct usb_descriptor_header *hs_audio_desc[] = { > }; > > struct cntrl_cur_lay3 { > - __u32 dCUR; > + __le32 dCUR; > }; > > struct cntrl_range_lay3 { > - __u16 wNumSubRanges; > - __u32 dMIN; > - __u32 dMAX; > - __u32 dRES; > + __le16 wNumSubRanges; > + __le32 dMIN; > + __le32 dMAX; > + __le32 dRES; > } __packed; > > static void set_ep_max_packet_size(const struct f_uac2_opts *uac2_opts, > @@ -703,9 +703,9 @@ in_rq_cur(struct usb_function *fn, const struct usb_ctrlrequest *cr) > memset(&c, 0, sizeof(struct cntrl_cur_lay3)); > > if (entity_id == USB_IN_CLK_ID) > - c.dCUR = p_srate; > + c.dCUR = cpu_to_le32(p_srate); > else if (entity_id == USB_OUT_CLK_ID) > - c.dCUR = c_srate; > + c.dCUR = cpu_to_le32(c_srate); > > value = min_t(unsigned, w_length, sizeof c); > memcpy(req->buf, &c, value); > @@ -742,15 +742,15 @@ in_rq_range(struct usb_function *fn, const struct usb_ctrlrequest *cr) > > if (control_selector == UAC2_CS_CONTROL_SAM_FREQ) { > if (entity_id == USB_IN_CLK_ID) > - r.dMIN = p_srate; > + r.dMIN = cpu_to_le32(p_srate); > else if (entity_id == USB_OUT_CLK_ID) > - r.dMIN = c_srate; > + r.dMIN = cpu_to_le32(c_srate); > else > return -EOPNOTSUPP; > > r.dMAX = r.dMIN; > r.dRES = 0; > - r.wNumSubRanges = 1; > + r.wNumSubRanges = cpu_to_le16(1); > > value = min_t(unsigned, w_length, sizeof r); > memcpy(req->buf, &r, value); > -- > 2.18.0 >