Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp662492imm; Mon, 2 Jul 2018 20:04:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdTy2kfRqGVb/UN43Fcv2FB5FZVPdkVC2sbrSbgHi503c73o7n9QmDJmetApETZB3JuEohu X-Received: by 2002:a62:3d86:: with SMTP id x6-v6mr14330762pfj.192.1530587084523; Mon, 02 Jul 2018 20:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530587084; cv=none; d=google.com; s=arc-20160816; b=w96e0oscsdQw3xY50XVks1YR6xN1W962DEgi72Y32Hwye5CaD/U3MHQz5Gsn6EfpD1 dd2L28NFWaxr18euXAF9IB9AHgxGa5PBpMvX1WRoVtCtDBNbHYcf2EIv/IprP8gedDOE 7ojG/eiXTFoQGfpPDggmc19Nm/p+vsgv6EMHaF75kbpK7zSWf453XnsUeE+3hiqBFEdy x7uC855Ime9iuDbaGoVCmsLz1EqepWZ1z7yqMiLSoCtpctcPYu60Og4oL/0xTinfI3Kn HOeCeY9fkog3lVbfNBpQ1fj16nsmUN2/LI0bEAiEUU83xnSgxgBSAQh1GfIE37UHJDRX m+jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=dxbu4nA2nP/MbwitFReqzU5AdYkvVGJGwH3yEmljLT0=; b=hbHiny8wMhZixjrHbuliUdEKN1YISSLbQ7nB2ekNj19PhJdowjUA3z3fGkoKvmezgo bf3pGtiQGySdJLuyEjlUk07bHPnpb8IauXzhJV9w97TQnXW0eqKkQGFmhGp2hlvBKnaN Ou+IsrU2nDXV1Wrn5P2c9VL1Mco0xK/8GwLkvUHaSrLHZtV8LI6+XnoutIQnQCg8cfJI BtboiqJObCUFL5V1qZRcx6PYLaA3c15sums2No32owSm10MjLBcKnPqYJo89cRH80sSF w3Ro4uoUCU6UoILplepBTD+UgqdmzoZZg5LaoYc3CLYEM9IM8pIiZEU7jJAQybWECwB1 Dtfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=EGVsoveo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s64-v6si73183pfg.175.2018.07.02.20.04.30; Mon, 02 Jul 2018 20:04:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=EGVsoveo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932395AbeGCDDs (ORCPT + 99 others); Mon, 2 Jul 2018 23:03:48 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:60894 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841AbeGCDDl (ORCPT ); Mon, 2 Jul 2018 23:03:41 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w632whDK167829 for ; Tue, 3 Jul 2018 03:03:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : references : in-reply-to : from : date : message-id : subject : to : cc : content-type; s=corp-2017-10-26; bh=dxbu4nA2nP/MbwitFReqzU5AdYkvVGJGwH3yEmljLT0=; b=EGVsoveof28X1WnkRH44dB78CfcITSMGFBjR61C/e11x5j6cCXsfAb8UyTy/AxhGT281 rkhU8sWtT53WeSyeTDoRl33e9Nsa8m1KbKZPqyMdDAw/p8i+mGemb2QbtHXirsKMF41W Mez0ElVfMJ1pdrXTGLujqcsQqGSysJsEGPySXNe3ge5vuKhSoBhiOtY6Bme3E/R8kEuy TXF40UCQsJFW8IthoJGlAGtgRtqZUQPpjYiL5ZvEfTaq/8pCca8qrrOctlnK7dk4p6Bn R8+lwXzC+7cht+hHN9B4CwRKclVRdppI2GtAqcoO9TmwWt6BX/UEG9+o155AyFbLrr3/ dw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2jwyccpuvm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 03 Jul 2018 03:03:40 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6333cjs011938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 3 Jul 2018 03:03:38 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6333bhg026757 for ; Tue, 3 Jul 2018 03:03:38 GMT Received: from mail-oi0-f51.google.com (/209.85.218.51) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 02 Jul 2018 20:03:37 -0700 Received: by mail-oi0-f51.google.com with SMTP id c6-v6so922744oiy.0 for ; Mon, 02 Jul 2018 20:03:37 -0700 (PDT) X-Gm-Message-State: APt69E14qrbo/vlXEJzTxXo+JYRWOioEt2zMfBRuOJAd0uhLMnYtMUFe o1tW5mO6cQ/slu4Gth/8NUdHqpOJsmRSfUZ+plE= X-Received: by 2002:aca:edc1:: with SMTP id l184-v6mr17468960oih.65.1530587017079; Mon, 02 Jul 2018 20:03:37 -0700 (PDT) MIME-Version: 1.0 References: <1530239363-2356-1-git-send-email-hejianet@gmail.com> <1530239363-2356-3-git-send-email-hejianet@gmail.com> In-Reply-To: From: Pavel Tatashin Date: Mon, 2 Jul 2018 23:03:01 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64 To: Jia He Cc: linux@armlinux.org.uk, Andrew Morton , Michal Hocko , Catalin Marinas , Mel Gorman , will.deacon@arm.com, mark.rutland@arm.com, hpa@zytor.com, Daniel Jordan , AKASHI Takahiro , Gioh Kim , Steven Sistare , neelx@redhat.com, erosca@de.adit-jv.com, Vlastimil Babka , LKML , Linux Memory Management List , james.morse@arm.com, Ard Biesheuvel , steve.capper@arm.com, tglx@linutronix.de, mingo@redhat.com, gregkh@linuxfoundation.org, Kate Stewart , Philippe Ombredanne , Johannes Weiner , kemi.wang@intel.com, =?UTF-8?B?UGV0ciBUZXNhxZnDrWs=?= , yasu.isimatu@gmail.com, aryabinin@virtuozzo.com, nborisov@suse.com, Wei Yang , jia.he@hxt-semitech.com Content-Type: text/plain; charset="UTF-8" X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8942 signatures=668704 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=634 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807030033 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Can you put it into memblock.c > Do you think it looks ok if I add the inline prefix? I would say no, this function is a too complex, and is not in some critical path to be always inlined. I would put it into memblock.c, and have #ifdef CONFIG_HAVE_MEMBLOCK_PFN_VALID around it. Thank you, Pavel