Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <b07b6ae9-4b57-4b40-b9bc-50c2c67f1d91@default>
Date:   Mon, 2 Jul 2018 23:49:54 -0700 (PDT)
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
To:     <linux-kernel@vger.kernel.org>
Cc:     <mingo@redhat.com>, <x86@kernel.org>, <tglx@linutronix.de>,
        <srinivas.eeda@oracle.com>, <hpa@zytor.com>
Subject: [PATCH] x86/mm/32: Initialize CR4 shadow before __flush_tlb_all()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In x86_32, __flush_tlb_all() may have read cr4 shadow before the
initialization of cr4 shadow in cpuinit().

Fix it by adding cr4_init_shadow() call ahead of __flush_tlb_all().

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: Srinivas Reddy Eeda <srinivas.eeda@oracle.com>
---
 arch/x86/kernel/smpboot.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index c2f7d1d..db9656e 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -221,6 +221,11 @@ static void notrace start_secondary(void *unused)
 #ifdef CONFIG_X86_32
 =09/* switch away from the initial page table */
 =09load_cr3(swapper_pg_dir);
+=09/*
+=09 * Initialize the CR4 shadow before doing anything that could
+=09 * try to read it.
+=09 */
+=09cr4_init_shadow();
 =09__flush_tlb_all();
 #endif
 =09load_current_idt();
--=20
1.7.3