Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Jul 2018 09:10:55 +0100 (BST)
From:   Justin Skists <justin.skists@juzza.co.uk>
To:     w.d.hubbs@gmail.com, gregkh@linuxfoundation.org,
        speakup@linux-speakup.org, Tamir Suliman <tsuliman@linuxvaults.com>
Cc:     devel@driverdev.osuosl.org, chris@the-brannons.com,
        dhowells@redhat.com, linux-kernel@vger.kernel.org
Message-ID: <1527895743.93688.1530605455516@email.1and1.co.uk>
In-Reply-To: <1530603080-1353-1-git-send-email-tsuliman@linuxvaults.com>
References: <1530603080-1353-1-git-send-email-tsuliman@linuxvaults.com>
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Importance: Medium
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 03 July 2018 at 08:31 Tamir Suliman <tsuliman@linuxvaults.com> wrote:

> +++ b/drivers/staging/speakup/keyhelp.c
> @@ -167,7 +167,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
>  		synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO));
>  		build_key_data(); /* rebuild each time in case new mapping */
>  		return 1;
> -	} else {
> +	} else if {

Interesting construct...


> @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
>  			continue;
>  		}
>  
> -		index = simple_strtoul(cp, &temp, 10);
> +		index = simple_ktrtoul(cp, &temp, 10);

Did you compile this?


Justin.