Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp945617imm; Tue, 3 Jul 2018 02:50:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf3e0Gnt+93yIB9nUmL6tm7lvm9RdO+QQ3/evqeZq0yXWyPHAdNYcdir0qYleyqTuG/9b5m X-Received: by 2002:a62:5582:: with SMTP id j124-v6mr9110120pfb.20.1530611417876; Tue, 03 Jul 2018 02:50:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530611417; cv=none; d=google.com; s=arc-20160816; b=XJ81I9HY8UuCD+Ogd1ajrAxVYH01MqCwwGZoSsK8O1r2phHBL2DMsXKRS2LVBggd3/ hy55KT92Y8sZxoXf+yy2nQ3+jQVyT0/KMlQp2z13gcM1bp/ijVMX+T5QP9JsZzp51cnB FOKhMsdcC8+iOzpJj8APDiDKkmbKO5VuZBy4r1yFaiEq4xXPXX0mfd8AApVLwtOrY5vg m4XQpe3bCW1dUYIzLo1E6pKM9RPzP3NWv8RFeBrZHL/+NmeEBaQFsw2v6Qj4y8uDquhP +qdWupt5oA1Das/sUsrtlh53E59/D4RkB2oeAq5BcHemv3aW6VPYt6RQtthOz74T9bGO gUQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=8Ag1DBj6OFFseDUCZGKOaQUFUEtpdn4yJTBch39I4nI=; b=YqIeBffXzOUz0c5AsHqzDBrEI2VimQ/t84JIusERf+AMFfzweYz04TiuI98+l9rPOz ty1cfU7mhxIC+0R43C4N8Oz4MwLYvGqM9RARk+DFSx/Xl+DoraBca45G32W2wW1Ge/+c 9Pzw9gkq4uk8VgO7RuIE36wdq/vpX5JoB+RRY54b5xSjRTULCk9/ZuW22o9WYVqvC1P7 HvIfd4R7Gz9Tj01rUdovRaKIlu1kFybZG0rAOtQsJalMu9Z/9bHt0xqDQ7gNLEdg8v84 FTc1w15sHuhTdMYuTt0MJ7vATIoKGeYaCwOQMzodaHDSmCgSTQJEYvm8ixZ14nnd5A/c 2jUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a26-v6si651776pgf.557.2018.07.03.02.50.03; Tue, 03 Jul 2018 02:50:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbeGCJsK (ORCPT + 99 others); Tue, 3 Jul 2018 05:48:10 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45292 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754702AbeGCJsI (ORCPT ); Tue, 3 Jul 2018 05:48:08 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w639jHec058010 for ; Tue, 3 Jul 2018 05:48:08 -0400 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k06sqr2tw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Jul 2018 05:48:07 -0400 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Jul 2018 05:48:06 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Jul 2018 05:48:02 -0400 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w639m1oM1311270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Jul 2018 09:48:01 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C18CC28059; Tue, 3 Jul 2018 05:47:34 -0400 (EDT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5076028065; Tue, 3 Jul 2018 05:47:34 -0400 (EDT) Received: from sofia.ibm.com (unknown [9.124.35.39]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 3 Jul 2018 05:47:34 -0400 (EDT) Received: by sofia.ibm.com (Postfix, from userid 1000) id 541252E2F42; Tue, 3 Jul 2018 15:17:59 +0530 (IST) Date: Tue, 3 Jul 2018 15:17:59 +0530 From: Gautham R Shenoy To: Akshay Adiga Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, stewart@linux.vnet.ibm.com, benh@kernel.crashing.org, svaidy@linux.vnet.ibm.com, ego@linux.vnet.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au Subject: Re: [PATCH v3 2/2] powernv/cpuidle: Use parsed device tree values for cpuidle_init Reply-To: ego@linux.vnet.ibm.com References: <1530609656-13301-1-git-send-email-akshay.adiga@linux.vnet.ibm.com> <1530609656-13301-3-git-send-email-akshay.adiga@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1530609656-13301-3-git-send-email-akshay.adiga@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 x-cbid: 18070309-0060-0000-0000-000002865E6A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009300; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01055881; UDB=6.00541596; IPR=6.00833804; MB=3.00021975; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-03 09:48:04 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18070309-0061-0000-0000-000045A976D7 Message-Id: <20180703094759.GB24693@in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-03_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=967 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807030112 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Akshay, On Tue, Jul 03, 2018 at 02:50:56PM +0530, Akshay Adiga wrote: > Export pnv_idle_states and nr_pnv_idle_states so that its accessible to > cpuidle driver. Use properties from pnv_idle_states structure for powernv > cpuidle_init. > > Signed-off-by: Akshay Adiga > Reviewed-by: Nicholas Piggin > --- [..snip..] > > /* > * For nap and fastsleep, use default target_residency > * values if f/w does not expose it. > */ This comment can also go, since we are no longer hard-coding the residency values in the kernel. Otherwise looks good to me. Reviewed-by: Gautham R. Shenoy -- Thanks and Regards gautham.