Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1044261imm; Tue, 3 Jul 2018 04:40:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKLOjzn0DRlzgyrrDoSOx/ibqjIIvGX/iGHkvGW6b9qlqKeOQbL7hNQn/BXFWDlBhsYXq4S X-Received: by 2002:a17:902:8486:: with SMTP id c6-v6mr29375508plo.283.1530618056577; Tue, 03 Jul 2018 04:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530618056; cv=none; d=google.com; s=arc-20160816; b=W+sIHg3bAa1edpWNfmzlFjewrXjeApN3iYR1xY2HfbeQtf/79FyF3yMBcVt+3Dz+pd tFOp9g0u+LNUx+J9iylGoGfvHZolrAAa5eFUCDJJecENP73x8ZTgFb3wOkHUxCBzA3Ad Gx8kimaKA606auaEgBd3dWF0Ce0tuSyJLsHn5RI1pavobTge+ngleWpHPFpJwzu1bP0b qO6uCG7o4M9YQ0TW1ax+1z0Cz5xhbL1flIKpOHm9ap3zgJg5+pmmaQc2oxRcljCNjgUJ JfgTu7tAbZr/Rl1Sj+7zEkJs4X0s0F7chFa5znJcltqgdSnyW9KPdWJZGvvtFbKI1SLA 8iWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qTYcSHkqctsY21c/rqQXuL5tis74IiU6/HBeDUmru0U=; b=rgkJImbOmqYGnempP4FTYycyVQTWz2eYHeB2h4xEooaGVhCn0BQ4x0tfwQaDdIPQ3Y ixesczfL1al11Zo0fxfyj6g5UR6Y0rjbgCEfWiWgi66/aEoOxupJqqRsS65GaSsFAW+k T2SJscem0BjzPMYa9q7/mOBY7lBILjlMfvkkEp955/YXMABj/UfSORwJsCAsPy7BzKYC aM6FW9pgwdYpX+4FlfkmeZ7OJ4CaXX1RoUpJ5U8F+bBlIMkinFgzxnjSm2pHBFyx1d0U n1VMz/kge9U5++s3Rd/uCBzClv5Z5xNzuJs1A7lsC9If+SHaKraoxAyRTT05EMKbtevn TbCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b59-v6si967690plb.107.2018.07.03.04.40.41; Tue, 03 Jul 2018 04:40:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbeGCLjz (ORCPT + 99 others); Tue, 3 Jul 2018 07:39:55 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48010 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbeGCLjj (ORCPT ); Tue, 3 Jul 2018 07:39:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34D8B80D; Tue, 3 Jul 2018 04:39:39 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B1FFC3F5BA; Tue, 3 Jul 2018 04:39:37 -0700 (PDT) Date: Tue, 3 Jul 2018 12:39:35 +0100 From: Mark Rutland To: Andrea Parri Cc: linux-kernel@vger.kernel.org, Boqun Feng , David Sterba , Ingo Molnar , Kees Cook , Peter Zijlstra , Will Deacon Subject: Re: [PATCH] refcount: always allow checked forms Message-ID: <20180703113934.d2c5grjqwq5kuk4h@lakrids.cambridge.arm.com> References: <20180703100102.16615-1-mark.rutland@arm.com> <20180703103320.GA17809@andrea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180703103320.GA17809@andrea> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 03, 2018 at 12:33:20PM +0200, Andrea Parri wrote: > Hi Mark, > > a typo below: > > > > /** > > - * refcount_inc - increment a refcount > > + * refcount_inc_checked - increment a refcount > > * @r: the refcount to increment > > * > > * Similar to atomic_inc(), but will saturate at UINT_MAX and WARN. > > @@ -148,14 +146,14 @@ EXPORT_SYMBOL(refcount_inc_not_zero); > > * Will WARN if the refcount is 0, as this represents a possible use-after-free > > * condition. > > */ > > -void refcount_inc(refcount_t *r) > > +void refcount_inc_chcked(refcount_t *r) > > s/chcked/checked The kbuild test robot also just spotted this; I've fixed tht up locally and pushed it out to my atomics/refcount-checked branch. Thanks for the spot! Mark.