Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Jul 2018 13:47:03 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: sram: enable clock before registering regions
Message-ID: <20180703114703.GO9802@localhost>
References: <20180703100548.30214-1-johan@kernel.org>
 <20180703100548.30214-2-johan@kernel.org>
 <e736a83f-bdd9-d136-070d-7093f5e8be2c@mentor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e736a83f-bdd9-d136-070d-7093f5e8be2c@mentor.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 03, 2018 at 01:23:30PM +0300, Vladimir Zapolskiy wrote:
> Hi Johan,
> 
> On 07/03/2018 01:05 PM, Johan Hovold wrote:
> > Make sure to enable the clock before registering regions and exporting
> > partitions to user space at which point we must be prepared for I/O.
> > 
> > Fixes: ee895ccdf776 ("misc: sram: fix enabled clock leak on error path")
> > Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> thank you for the change, however please note that the identified commit
> for the fix is incorrect one apparently.
> 
> In my opinion the proper tag contents would be
> 
> Fixes: b4c3fcb3c71f ("misc: sram: extend usage of reserved partitions")
> 
> I hope you agree to it, also I would suggest to swap the changes in
> the series.

No, I think I used the right commit in the Fixes tag as that was the
commit which moved the clock enable to after the memory-region
registration (at which point the memory could potentially be accessed).

Johan