From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Ronny Buchmann <ronny-lkml@vlugnet.org>
Subject: Re: [OOPS] 2.4.22 / HPT372N
Date: Fri, 12 Sep 2003 16:42:19 +0200
User-Agent: KMail/1.5
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Marko Kreen <marko@l-t.ee>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <200309091406.56334.ronny-lkml@vlugnet.org> <200309121458.25327.bzolnier@elka.pw.edu.pl> <200309121624.41989.ronny-lkml@vlugnet.org>
In-Reply-To: <200309121624.41989.ronny-lkml@vlugnet.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200309121642.19966.bzolnier@elka.pw.edu.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1194
Lines: 34

On Friday 12 of September 2003 16:24, Ronny Buchmann wrote:
> Am Freitag 12 September 2003 14:58 schrieb Bartlomiej Zolnierkiewicz:
> > On Friday 12 of September 2003 12:48, Alan Cox wrote:
> > > On Gwe, 2003-09-12 at 10:41, Ronny Buchmann wrote:
> > > > -	d->channels = 1;
> > > > +	d->channels = 2;
> > >
> > > Need to work out which 372N and others are dual channel but yes
> >
> > No, "d->channels = 1" is only executed for orginal HPT366 which has
> > separate PCI configurations for first and second channel.  For HPT372N
> > you have correct value in hpt366.h - ".channels = 2".
>
> so it should be something like this?
>
> switch(class_rev) {
> 	case 5:
>  	case 4:
>   	case 3: ide_setup_pci_device(dev, d);
> 		return;
> 	case 1: d->channels = 1;
> 	default:        break;
> }

No.  I don't know about HPT368, but current code should be correct.
Note that for HPT372N class_rev is set to 5 just before this switch statement.

--bartlomiej

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/