Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1349834imm; Tue, 3 Jul 2018 09:35:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJZR6z2+kgzShgsINA47C6ClD5+Kzl/KqUTDa3HnxxB6mf5hq1U7rK+t4JzJxq9tol/b+qB X-Received: by 2002:a63:64c2:: with SMTP id y185-v6mr25959760pgb.126.1530635713002; Tue, 03 Jul 2018 09:35:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530635712; cv=none; d=google.com; s=arc-20160816; b=oKdacX7d0JDF5M4YIBYTe7gHJsh4X24S+mo1lEegdCP3meMD0RtBoC28LrR0yrmbyh BaohJNE8Sn+W5k7l3hXeE97+Srkl6zWEa21V/etEHJr+G6BSvvUkZzyoVJ96TRZrzBSw KmRiAU3QwW1FhEbp7eiIS+16F+FbvWk0L1cdfj2TUKHP5qrHb6+NWV4piiK9xbqoxNRc CZskSPDOJshPV+KYahg4kdgjgG0eskgch/MOpgVDRfUs/OCtHpn4o7tD9KdmSbJ/y7xX py9LuP3XgUet5OhL7xkhQ+fUk/dd55R49ridNIMq1AK6tbu+seEWvJhKt7l4ofMUvsTJ U97g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:date:cc:to:from:subject :message-id:arc-authentication-results; bh=Ty99tcfGXEdjP+lAFr34rBAJatr6seQY8jiFUKfSDlg=; b=QnOQchewuNJksER44G1qGljPq80/zAoNyb3+5sA56jIQGm+MY4eRI90Z5yTHsoJH0c nVOeKWMUkPDto6pn9Q0zhUnuvfTuEk548cINfB/BTo83SUlodtH5ZiaYvZc7QV4OaPmN cBCq3WpJ+kv/TiciHYfxhgemNFnu5BIrpb0y08YlQwUuNhTT7SYq3AD7ztZkgEQzocru xupZayeZ6/R6CMSxRopLfCXD2xT5TtEC2P3+MdEcE8HllopRV1cvRLHh4rCNWJCYkXNG aEVO9JTtwddsN1OQQztc7h2BYp9vWmvmHGUw2RcC1yfx5d3CQPz0ofMpEuhcAEJUKS8+ NRpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1-v6si1309688pga.205.2018.07.03.09.34.58; Tue, 03 Jul 2018 09:35:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933677AbeGCQcO (ORCPT + 99 others); Tue, 3 Jul 2018 12:32:14 -0400 Received: from mga12.intel.com ([192.55.52.136]:31614 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbeGCQcN (ORCPT ); Tue, 3 Jul 2018 12:32:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 09:32:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="68360855" Received: from cdikicix-mobl.ger.corp.intel.com ([10.249.254.69]) by fmsmga004.fm.intel.com with ESMTP; 03 Jul 2018 09:32:08 -0700 Message-ID: <1a5b3d6cddba2d8bc74e5025a628aee7867a8987.camel@linux.intel.com> Subject: Re: [PATCH] ima: Use tpm_default_chip() and call TPM functions with a tpm_chip From: Jarkko Sakkinen To: Mimi Zohar , Stefan Berger , linux-integrity@vger.kernel.org Cc: jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Date: Tue, 03 Jul 2018 19:32:07 +0300 In-Reply-To: <1530550839.3709.46.camel@linux.vnet.ibm.com> References: <20180702152449.3219288-1-stefanb@linux.vnet.ibm.com> <1530550839.3709.46.camel@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-07-02 at 13:00 -0400, Mimi Zohar wrote: > On Mon, 2018-07-02 at 11:24 -0400, Stefan Berger wrote: > > Rather than accessing the TPM functions by passing a NULL pointer for > > the tpm_chip, which causes a lookup for a suitable chip every time, get a > > hold of a tpm_chip and access the TPM functions using it. Also get rid of > > the ima_used_chip variable and use the new ima_tpm_chip variable instead > > for determining whether to call TPM functions. > > > > Signed-off-by: Stefan Berger > > Acked-by: Jarkko Sakkinen > > Signed-off-by: Mimi Zohar > > Jarkko, would you mind staging this patch with the rest of the patch > set? Yes, sure, I can do that. Any additional tag? /Jarkko