Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1363422imm; Tue, 3 Jul 2018 09:49:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeXriifEB210/H5xV4/BUylCi8MhwGU2LvOxaZQXQ+L3XEdzKfeL/dJiRX0ZBmfgtkn+lq8 X-Received: by 2002:a17:902:b717:: with SMTP id d23-v6mr5082384pls.105.1530636572384; Tue, 03 Jul 2018 09:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530636572; cv=none; d=google.com; s=arc-20160816; b=0pf2zDzA5omRMHtwdd7bFOOH2TrfG5gGFu7/DtGibar+jsa8aBeGZvkIAQM395C05M qzyGpJhDieJ5TwqXriXSUnWhA4JgG1ZKGVMamg39gpHCnixRZRMdeHPq9BBBDxPYYCmI I9ia6RD5feaBHQ4QWwgWd2NNIX1HT1q1ZfOJoWWpZkGDa7pC96nllyxyrC4waYWC5TdV xiExAtGfTNqXRkgx2pVms1OW4Ab5A6mphx78Qd9AtFzW6pdUBrAMy6OZw0mKDaDVqAdM DEo359RqHEbjMafzmNX2vh9x+ekEZQIaWQyEA0Z5LmN1GQIeH4ZRUNxoS59HWzL+T29x hssg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=pYVcqEEzFcG++F7MI+sLuuxxX3XUGyO3pwICl05P3TU=; b=B7Prg78c0oKtQrrRb5Dm9X0m5vmaodxl2RyUHlyHFPfTRoPnLjlwZ8DVbI671pikhE lAMUSE69fzDh0sWNm10bT+7Fol+REapzW4QN0SdDp360FXBUyAf/3wsrY0XiOaXhgS+y ZuNJApv3aWCO8hophAJr7+f0aRi290cPgF9l0gmnHVG2CQImXasOY81b0YToL0pK54yK 5cOr5ThJFdIDq2VhXtsocf7NY2VxMFoR4J6ypCCwRa8MQtaLv+jiJ11qm7G5H86Trcbg oeOXPJSwdwRZwgovWhEEDAlgPXvhpY7+TZH8OavPeCDkQkPFgh/4g2wn5yBCgRakYQ3i SHCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13-v6si1438041plr.220.2018.07.03.09.49.18; Tue, 03 Jul 2018 09:49:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934177AbeGCQrp (ORCPT + 99 others); Tue, 3 Jul 2018 12:47:45 -0400 Received: from mga17.intel.com ([192.55.52.151]:62863 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933860AbeGCQrn (ORCPT ); Tue, 3 Jul 2018 12:47:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 09:47:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="242334720" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by fmsmga005.fm.intel.com with ESMTP; 03 Jul 2018 09:47:42 -0700 Date: Tue, 3 Jul 2018 10:47:41 -0600 From: Ross Zwisler To: Dan Williams Cc: mingo@kernel.org, Al Viro , Andrew Morton , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Tony Luck , Ross Zwisler , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] lib/iov_iter: Fix pipe handling in _copy_to_iter_mcsafe Message-ID: <20180703164741.GA30451@linux.intel.com> Mail-Followup-To: Ross Zwisler , Dan Williams , mingo@kernel.org, Al Viro , Andrew Morton , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Tony Luck , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <153046008813.2019.6356018879675062644.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153046008813.2019.6356018879675062644.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 01, 2018 at 08:52:20AM -0700, Dan Williams wrote: > By mistake the ITER_PIPE early-exit / warning from copy_from_iter() was > cargo-culted in _copy_to_iter_mcsafe() rather than a machine-check-safe > version of copy_to_iter_pipe(). > > Implement copy_pipe_to_iter_mcsafe() being careful to return the > indication of short copies due to a CPU exception. > > Without this regression-fix all splice reads to dax-mode files fail. > > Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()") > Cc: Al Viro > Cc: Andrew Morton > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Tony Luck > Reported-by: Ross Zwisler > Signed-off-by: Dan Williams Tested-by: Ross Zwisler