Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Jul 2018 09:58:49 -0700
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Prarit Bhargava <prarit@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-edac@vger.kernel.org
Subject: Re: [PATCH] x86/MCE: Fix CPU microcode version output
Message-ID: <20180703165849.GA17773@agluck-desk>
References: <20180703164844.9742-1-prarit@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180703164844.9742-1-prarit@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 03, 2018 at 12:48:44PM -0400, Prarit Bhargava wrote:
> On systems where a runtime microcode update has occurred the
> microcode version is wrong because boot_cpu_data.microcode is
> not updated during runtime.
> 
> Use the per-CPU microcode version in the MCE message.

Other option would be to fix the microcode update code to make
sure that boot_cpu_data.microcode is right.

But if we go this route we should add:

Fixes: fa94d0c6e0f3 ("x86/MCE: Save microcode revision in machine check records")
Cc: stable@vger.kernel.org

Can also get a:

Reviewed-by: Tony Luck <tony.luck@intel.com>

-Tony Luck