Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp357750imm; Tue, 3 Jul 2018 21:11:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpetBQRzYpd89q5/0mC+zMkfAdzeQKjsudpIyQs7se84jva5J/257crcfKBIFsfqMj0uotTu X-Received: by 2002:a63:614d:: with SMTP id v74-v6mr417499pgb.328.1530677515299; Tue, 03 Jul 2018 21:11:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530677515; cv=none; d=google.com; s=arc-20160816; b=l/56bHlfPwKNBtuP3yz1zYLTvhCZOx16wLu1sjwYS3yJmIjxvlS29YvvFr3sZY4MIf IiaFVoeVzuI8m/er+PrzKKS1cqo8kVgJlEp47f2CmkameopvSTyhPNsyBaSDO8D9oBVi QLAQ/6G6MEY80UgUEDsT4qh1Sy1MBPrzoLyspsteKyd8VXnc+gQo7zAaYmFWzZijUUCc f7XjyE9OYg+f5WZScmgegOIaTkG/aHsNKt79+jUsUmyWgHz0NTnDhSr3KXly72LGPaUb EPFeTdkHWpF67H+T5aZJTeo4I1sNRF7AD6r2LvCCkgKq+0KinVnwvbvdhShzACC5KY9q 7b6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=j0kTZKJujzgtLPcZP44Pv+vDu4CPULN2DQMCE/yX5Mo=; b=S/mZX0qc7L/tc/+XDG1W7LH6D3r2o3/xG8YbdfyrU52JoS7qflOymkJf04IN10/3fo wrRFnZgKNetcQ1da6VjfCq0JUcGVXlYq8jL4OW0r4Q4kiHPQEY4fiqZy3GzHDN+5do+s RUCnHlO6+vxTqyJapwOgf05QygKu7MYBEJwKZaYG4m6LBqQfZRyP7Z7JgPKu3o8ubDmu KYxl6q812JxzZjBd6ZLJryyw+8PXrQO4fniBBV4BTboESIlAInNMkfo71g+OLqXU6HqB K3iFk469M/xqlBT7CN+RjnsTgqyat8PFrOq0dZMC5VdTGBR1he3dxl2cwhddFdAYLhid G71A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8-v6si2268401pgp.293.2018.07.03.21.11.40; Tue, 03 Jul 2018 21:11:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbeGDELD (ORCPT + 99 others); Wed, 4 Jul 2018 00:11:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60098 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750928AbeGDELB (ORCPT ); Wed, 4 Jul 2018 00:11:01 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 229AE406AE3F; Wed, 4 Jul 2018 04:11:00 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1858C2026D76; Wed, 4 Jul 2018 04:10:40 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, robh+dt@kernel.org, dan.j.williams@intel.com, nicolas.pitre@linaro.org, josh@joshtriplett.org, fengguang.wu@intel.com, bp@suse.de, andy.shevchenko@gmail.com Cc: patrik.r.jakobsson@gmail.com, airlied@linux.ie, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, dmitry.torokhov@gmail.com, frowand.list@gmail.com, keith.busch@intel.com, jonathan.derrick@intel.com, lorenzo.pieralisi@arm.com, bhelgaas@google.com, tglx@linutronix.de, brijesh.singh@amd.com, jglisse@redhat.com, thomas.lendacky@amd.com, gregkh@linuxfoundation.org, baiyaowei@cmss.chinamobile.com, richard.weiyang@gmail.com, devel@linuxdriverproject.org, linux-input@vger.kernel.org, linux-nvdimm@lists.01.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, ebiederm@xmission.com, vgoyal@redhat.com, dyoung@redhat.com, yinghai@kernel.org, kexec@lists.infradead.org, monstr@monstr.eu, davem@davemloft.net, chris@zankel.net, jcmvbkbc@gmail.com, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, seanpaul@chromium.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Baoquan He Subject: [PATCH v6 0/4] resource: Use list_head to link sibling resource Date: Wed, 4 Jul 2018 12:10:34 +0800 Message-Id: <20180704041038.8190-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 04 Jul 2018 04:11:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 04 Jul 2018 04:11:00 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset is doing: 1) Replace struct resource's sibling list from singly linked list to list_head. Clearing out those pointer operation within singly linked list for better code readability. 2) Based on list_head replacement, add a new function walk_system_ram_res_rev() which can does reversed iteration on iomem_resource's siblings. 3) Change kexec_file loading to search system RAM top down for kernel loadin, using walk_system_ram_res_rev(). Note: This patchset only passed testing on x86_64 arch with network enabling. The thing we need pay attetion to is that a root resource's child member need be initialized specifically with LIST_HEAD_INIT() if statically defined or INIT_LIST_HEAD() for dynamically definition. Here Just like we do for iomem_resource/ioport_resource, or the change in get_pci_domain_busn_res(). v5: http://lkml.kernel.org/r/20180612032831.29747-1-bhe@redhat.com v4: http://lkml.kernel.org/r/20180507063224.24229-1-bhe@redhat.com v3: http://lkml.kernel.org/r/20180419001848.3041-1-bhe@redhat.com v2: http://lkml.kernel.org/r/20180408024724.16812-1-bhe@redhat.com v1: http://lkml.kernel.org/r/20180322033722.9279-1-bhe@redhat.com Changelog: v5->v6: Fix code style problems in reparent_resources() and use existing error codes, according to Andy's suggestion. Fix bugs test robot reported. v4->v5: Add new patch 0001 to move duplicated reparent_resources() to kernel/resource.c to make it be shared by different ARCH-es. Fix several code bugs reported by test robot on ARCH powerpc and microblaze. v3->v4: Fix several bugs test robot reported. Rewrite cover letter and patch log according to reviewer's comment. v2->v3: Rename resource functions first_child() and sibling() to resource_first_chils() and resource_sibling(). Dan suggested this. Move resource_first_chils() and resource_sibling() to linux/ioport.h and make them as inline function. Rob suggested this. Accordingly add linux/list.h including in linux/ioport.h, please help review if this bring efficiency degradation or code redundancy. The change on struct resource {} bring two pointers of size increase, mention this in git log to make it more specifically, Rob suggested this. v1->v2: Use list_head instead to link resource siblings. This is suggested by Andrew. Rewrite walk_system_ram_res_rev() after list_head is taken to link resouce siblings. Baoquan He (4): resource: Move reparent_resources() to kernel/resource.c and make it public resource: Use list_head to link sibling resource resource: add walk_system_ram_res_rev() kexec_file: Load kernel at top of system RAM if required arch/arm/plat-samsung/pm-check.c | 6 +- arch/microblaze/pci/pci-common.c | 41 +---- arch/powerpc/kernel/pci-common.c | 39 +---- arch/sparc/kernel/ioport.c | 2 +- arch/xtensa/include/asm/pci-bridge.h | 4 +- drivers/eisa/eisa-bus.c | 2 + drivers/gpu/drm/drm_memory.c | 3 +- drivers/gpu/drm/gma500/gtt.c | 5 +- drivers/hv/vmbus_drv.c | 52 +++--- drivers/input/joystick/iforce/iforce-main.c | 4 +- drivers/nvdimm/namespace_devs.c | 6 +- drivers/nvdimm/nd.h | 5 +- drivers/of/address.c | 4 +- drivers/parisc/lba_pci.c | 4 +- drivers/pci/controller/vmd.c | 8 +- drivers/pci/probe.c | 2 + drivers/pci/setup-bus.c | 2 +- include/linux/ioport.h | 21 ++- kernel/kexec_file.c | 2 + kernel/resource.c | 263 ++++++++++++++++++---------- 20 files changed, 248 insertions(+), 227 deletions(-) -- 2.13.6