Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp446140imm; Tue, 3 Jul 2018 23:21:37 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeTCfjdZW+F3OlcpDwcT2rGjXbzZgda0vNrZbKILWgfFHgdvcUNOr+2EMv0ZToHRuBUaWbm X-Received: by 2002:a62:d39b:: with SMTP id z27-v6mr828180pfk.182.1530685297903; Tue, 03 Jul 2018 23:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530685297; cv=none; d=google.com; s=arc-20160816; b=S/PLPOFM4f7+XeU140exKMGsO7gAOZr5kkP1FYyYd/j4K4Ie277KiJodJ6WWaz215O XG0HhLGZaH/WjItdZpHPdEzV28FMuJLNdr182VSBa/+VgAUISLXSsm3nHolBfirPRpjl 0mECUdMd3nDnzi2q5uY2uxd13bTHOXELVqfpcaxkaTVVq8/c+8SdkXMFet+RcGzZfTjZ oze779mlWE2pHofYzA/RBGu4xAxKkgQ4/lrawG91VVX4NAhSz7qE3DrSCYcqXkn2Hdid CkKcZGZj4153Dkz1vPgowGZ5AtCTYj3bzDAhPr6Ba36pl0oZRTABbj3L1QDAAx3ijmK9 cEmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=pdvh8sKU/akjuiRfzctgTxcLv3L5269QGHyotQqXVH8=; b=UHxQht7N2dM9Vf5PpU0DVDff5XStb5p1OdAls4ZyVb4K62V58rhOgq6gHz2fyLXSe3 F6TALxavl+pW6fPZjXiS99HuuLQldyVb2C2KnVLaMyR+b1mWlsDf882FpAusbLhwqN6s tOzo45MwflD9EPhFuvLsdjK0qh0vfQQ3Q6d/oyu0Cg0F1GWV3NWehDgM82z+1imOZHX7 BpgZhoq75SD4mkH92Pdg/VlI+YAusBAu9YGZ6/AruP5B+x6Xl42c/6V9fK6xXKFIPek7 23ec77M1rx0ljM059i7ZuB0uE7csN4WFrc5zn3/g+U8rCUZLb9jZhEoM+geC14zaxwFD +xHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QhY64nfP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n22-v6si2787147pff.370.2018.07.03.23.21.23; Tue, 03 Jul 2018 23:21:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QhY64nfP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933534AbeGDGUk (ORCPT + 99 others); Wed, 4 Jul 2018 02:20:40 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:44397 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933464AbeGDGUf (ORCPT ); Wed, 4 Jul 2018 02:20:35 -0400 Received: by mail-wr0-f194.google.com with SMTP id r16-v6so919960wrt.11 for ; Tue, 03 Jul 2018 23:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=pdvh8sKU/akjuiRfzctgTxcLv3L5269QGHyotQqXVH8=; b=QhY64nfPrLV/JCC9g3qEqxnS+70DpKnVhqed/c1PsLHxRiJD+BQUIKOiRc5keJ0fOk lDhzmiPuH0AzaLVpiaARR9EHQHKY8KrfCwPAl2dhgA/bXOIaYY6xRc3E3FvBUYmg0Rgg DOsSGtTfxn/cVtHjTiPfPgcjvxxrGod56XNNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pdvh8sKU/akjuiRfzctgTxcLv3L5269QGHyotQqXVH8=; b=PK9vxiTYgDNpMjETf+MvYISJ2KoEirsj6AqQj5CE+7/GNxYJjn0hZXDN4nL11vYxH1 6IN4rZvK+71Z+Ccr/SD++8LYs38fS/xDqEl3Xe/m3/5dr5hMNGehAJ6+a9+TffFqj0or RlaT501ASOP4yytewCxkzoItp4hG4/PdiADPQ0Qs4j2RtoUq7/4SX4Dmr99RyOhAlrOv Q6O+kr4aVGlcI/aSwdRflc9KHYG1XuOPnZIGHJxePmcpN83KoMrUXrlAfRWlAQAR88k+ M5aNPqDRCjzuuPCDCmT8z/s311X0q1NhLth1iqHJ0fNJmGa+Muox7alX1qAzVtf8vD7g Rjaw== X-Gm-Message-State: APt69E1lIFQHfvskdILc4fK/9ixOLLtslGvNNUe0uvXdruip9ePX1+l7 UJt/HaB3kk+fA7CvnhGiMY3QSQ== X-Received: by 2002:adf:9e48:: with SMTP id v8-v6mr466032wre.277.1530685234706; Tue, 03 Jul 2018 23:20:34 -0700 (PDT) Received: from dell ([2.27.167.87]) by smtp.gmail.com with ESMTPSA id d10-v6sm3313116wrj.38.2018.07.03.23.20.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 23:20:33 -0700 (PDT) Date: Wed, 4 Jul 2018 07:20:32 +0100 From: Lee Jones To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: kempld-core: constify variables that point to const structure Message-ID: <20180704062032.GX20176@dell> References: <1528865289-3875-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1528865289-3875-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jun 2018, Julia Lawall wrote: > Add const to the declaration of various local variables of type > kempld_platform_data for which the referenced value is always only > dereferenced or passed to a const parameter, to record the fact that > kempld_platform_data_generic is declared as const. > > The semantic match that finds this issue is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > identifier i,j; > @@ > const struct i j = { ... }; > > @ok@ > identifier r.i; > position p; > @@ > const struct i@p * > > @@ > identifier r.i; > position p != ok.p; > @@ > * struct i@p * > // > > Signed-off-by: Julia Lawall > > --- > drivers/mfd/kempld-core.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog