Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp466618imm; Tue, 3 Jul 2018 23:50:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcnyWk9dd1HEkHYAY/w92KeoWWIsc4pK3WPlhNtCIDJfSVVsblEn5Xh9TAvHzrvxwKXEK8D X-Received: by 2002:a63:9246:: with SMTP id s6-v6mr781525pgn.35.1530687031481; Tue, 03 Jul 2018 23:50:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530687031; cv=none; d=google.com; s=arc-20160816; b=ENojZTiBlT8Wc8kOv0xkTMDckwmnMqsM1y4OB2wKlrMgh94W1ioJ/vSVydoMNoY8Xa rGR/GsMvxjC/7hQDDPN8aC9uhfznEiUcR1b8B38MnL8gFMqsD2aEtgCDkMGE4q/bIs7E HjGSfhjvcmqpAzXLiDn8flQWv/EyNbmI5qGgNl/rKgUCLO1EF44sadTz+6/jKffvo8u7 jR8qnmyQBrrvhlomUWvIaxkWDXS0Z9PV9lHQmGv1G7JPgrVpGqYevvSUchRvTJ9W8PKi FTQOv+5MsBP/wXf1NtOXIhb/F2sral+A+bK4ZmzbDbInwz+ywTQpMavLj6KCQgSUvjs5 AWVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :message-id:references:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=rJYhblh9reEBkMvyksauJCS0df9HciAENbUQj9+4AUI=; b=pqvCb0NQK8M4UZhdZeGL1YJl7PVxbu55FyuXnnNqlAxyDo1CHXK1zpMzrJmBFMIEgN 1Arun+xF8fsnszBD92GmpIG1AmvyqKGqQbUbdbaxFK9ycqU9oC5zWG1lyP8PSGPtmmcf 3LblFg2osf/RPIq7bM9Wqj/b7MyYodgOXzG4KrZH2DMPFe5UruatxhduWpzAdYUeWAk4 16qlLVSCfGWghiMTzIbT7AW24CCmGEcDLPpzCoODQilw4NCwK35j3AdfyOyE3W2GkPoo U7CQhtn1bhuXouOshAv6Xy98L302AR0ccRZrHcu6QV79Yk8MBE6es09y3MU0HhKmS4Mw uq0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a16-v6si2712889pga.168.2018.07.03.23.50.17; Tue, 03 Jul 2018 23:50:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933631AbeGDGsM convert rfc822-to-8bit (ORCPT + 99 others); Wed, 4 Jul 2018 02:48:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58256 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932376AbeGDGsK (ORCPT ); Wed, 4 Jul 2018 02:48:10 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w646iLG0106330 for ; Wed, 4 Jul 2018 02:48:10 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k0qjquuq6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Jul 2018 02:48:10 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Jul 2018 07:48:08 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 4 Jul 2018 07:48:06 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w646m5ng38207624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Jul 2018 06:48:05 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56E1E4C050; Wed, 4 Jul 2018 09:48:30 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2003C4C04E; Wed, 4 Jul 2018 09:48:30 +0100 (BST) Received: from mschwideX1 (unknown [9.145.173.183]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 4 Jul 2018 09:48:30 +0100 (BST) Date: Wed, 4 Jul 2018 08:48:02 +0200 From: Martin Schwidefsky To: Kees Cook Cc: linux-kernel@vger.kernel.org, "Philippe Ombredanne" Subject: Re: [PATCH] RAID/s390: Remove VLA usage In-Reply-To: <20180703195221.GA11066@beast> References: <20180703195221.GA11066@beast> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) X-TM-AS-GCONF: 00 x-cbid: 18070406-0028-0000-0000-000002D7FDCB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18070406-0029-0000-0000-0000238F82C9 Message-Id: <20180704084802.6ba4dc30@mschwideX1> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-04_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807040081 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Jul 2018 12:52:21 -0700 Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this moves > the "$#" replacement from being an argument to being inside the function, > which avoids generating VLAs. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Signed-off-by: Kees Cook > --- > lib/raid6/s390vx.uc | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) Added to s390:features for the next merge window. Thanks. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.