Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp653122imm; Wed, 4 Jul 2018 03:43:42 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeNeQ0QAm4uMpsiu+9TsDSmYYsYpET8/NAZgLX/kcahmRLAslzE0pDvU68sfRL9Tkz6U0+0 X-Received: by 2002:a17:902:8209:: with SMTP id x9-v6mr1599111pln.150.1530701022455; Wed, 04 Jul 2018 03:43:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530701022; cv=none; d=google.com; s=arc-20160816; b=sIH2LcwsKhSJgcogBoImnc3Jmh1/lmI6/mNDd2K9Xo4oqZaxrOyi3jNIPt+qYe3WlE kog19tTvgWFidCKw4ZF/mFwpdIlejyqketLPklZMbPlLvalTpCc5x+N+aE/6Z5iTBHtz KgTBK1DlGJpzUr/+jlexAAFoU5YIxRZtFHJcRpDhg3Mbn5VxIj1aOYNG4Ns+tD83TcP0 JmIfd7QeOpM1tPFaOlRSm0N653XMjhbWAefMMSY+cMWU3cxiWyo3YsyXyDcLlml81hp+ YzykAU9FexxEzY+4e5xoNAnkxkipTIsK3xlhMt9rUn96xYXrCPf17cvFo2mE1FnpacUj qI0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=CCvQWsyg9zYAuDqR0QlCS/WvGR61aQDeFe6bcnrvU2w=; b=keZjKaqRej2gAgknPAbHaelUKe+7fxahFJdtI5ed8BVEyDqEXNK4TJ09IT7euzrtrw jbRHK1jlCZcG3r0/hGQi5U7jp2PwtneaBddJeNpO6WsU0BvbK7qX0g/5Y7jz1qzvLAEi 8JaicnJNPtTwIXU3aLfygdMpeCJtrl9E4YIDoir13FvcT1K1++EsZQTfZ5E/FK7ZVcwO HFBgdddvNXFJZJFUiNyG1sAXsYx+NMrepkIvk7nHXBx44LuNqM8XN7BeqZNYbUBjXeHT 4gv3+9/bWx30wTsNJTa0ROMKyY/jnAn2nFgzmltBfQCOrg1cL7clxHiDbKtCQFjyp18b Q+Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10-v6si3386752pfk.228.2018.07.04.03.43.28; Wed, 04 Jul 2018 03:43:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbeGDKms (ORCPT + 99 others); Wed, 4 Jul 2018 06:42:48 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:57180 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbeGDKmq (ORCPT ); Wed, 4 Jul 2018 06:42:46 -0400 Received: from 79.184.254.38.ipv4.supernova.orange.pl (79.184.254.38) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id fd696afe2ef2c390; Wed, 4 Jul 2018 12:42:44 +0200 From: "Rafael J. Wysocki" To: Matthias Kaehlcke Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris , Douglas Anderson , Enric Balletbo i Serra , Viresh Kumar , Lee Jones , Benson Leung , Olof Johansson Subject: Re: [PATCH v5 08/12] cpufreq: Add stub for cpufreq_update_policy() Date: Wed, 04 Jul 2018 12:41:21 +0200 Message-ID: <2392356.ug1cyb9g3O@aspire.rjw.lan> In-Reply-To: <20180703234705.227473-9-mka@chromium.org> References: <20180703234705.227473-1-mka@chromium.org> <20180703234705.227473-9-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 4, 2018 1:47:01 AM CEST Matthias Kaehlcke wrote: > cpufreq stubs out some functions when CONFIG_CPU_FREQ=n , but > cpufreq_update_policy() is not among them. The throttler driver > (https://patchwork.kernel.org/patch/10453351/) uses cpufreq as one > possible throttling mechanism, but it can still be useful without > cpufreq. Stubbing out cpufreq_update_policy() allows the throttler > driver to be built without ugly #ifdef'ery when cpufreq is disabled. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Brian Norris > --- > Changes in v5: > - none > > Changes in v4: > - added 'Reviewed-by: Brian Norris ' tag > > Changes in v3: > - patch added to series > --- > include/linux/cpufreq.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index 882a9b9e34bc..dba8c4951e2e 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -210,6 +210,7 @@ static inline unsigned int cpufreq_quick_get_max(unsigned int cpu) > return 0; > } > static inline void disable_cpufreq(void) { } > +static inline void cpufreq_update_policy(unsigned int cpu) { } > #endif > > #ifdef CONFIG_CPU_FREQ_STAT > I can take this patch if you want me to. Thanks, Rafael