Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1007222imm; Wed, 4 Jul 2018 09:43:22 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfHCsbpdLNiYlrIn3rAl68zOM9ucLADKIEaYKw0XvDT0Lig3I3bKopZl6sBU/wXHQdC7zSI X-Received: by 2002:a17:902:6047:: with SMTP id a7-v6mr2798325plt.188.1530722601982; Wed, 04 Jul 2018 09:43:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530722601; cv=none; d=google.com; s=arc-20160816; b=t1KIYwgaaVrhkdGx0xGHNNIdC0p82sN0wfLBosNyaQpX9P8H3vYRLAigcFP76r/ASL VJuw8JBQMYwxEhgHOv13S9KN/tqjpPw7ZDQptkwtJgN646wJXsw34PVx4dgMOU7OtOpG 8C7PWBplWax1GcFUUzPxCbvuNKt1YoMTABsW+jv36srsDMIT5GddFXuf1K4QPQZfYWSD qZx+AKhIrWvR83p6dXjtfxXb7a7tV/tI2kimAIdHGE5ZsZtLiGskozJ6Q8YjnWR5Elqk 9Im8jNyAj9vD1aDNel6LNicvlTRvnk1EMUr6pUpQZgOAtjy7CdfdH5lXWeLAio0gARI5 +IQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :domainkey-signature:arc-authentication-results; bh=CMWMz29i2KrpViPJlrND7FuCLp3KM/iz1M+1C0GWtHY=; b=olyPwiXcZ2Hy5ZEHYZvoZ9R/00dnrATBUGPXYUbDeyOp3I35CyEgj5uH7rgmLkGo1C xIXVy+w8YOSfEN8LbXUp6bemZImAaqKs1EiJMqEGcPq/SJXmRtUwdIUAOqbcu9kUSBT0 Z7z3av8Eit7ceQr+w6tqvjKS7UdhiJnA+F+I6QsigBKeMfVfolc2vGC5tvJMq/UR4/0A Cl/mJnEfqwmbXa5UrnEM5/IPFmQJouSS+IBxpsCvIHKv5TpsAF04nRAXwlhUykUkVf7H VtuI7vDsAsGzYk4f3SruYMoxf7AeezbQ133/KHrHnjRlYcMVFV+JbjR1ksfCyYuDM9Vj 33Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g16-v6si3431730pgv.78.2018.07.04.09.43.06; Wed, 04 Jul 2018 09:43:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752846AbeGDQkV (ORCPT + 99 others); Wed, 4 Jul 2018 12:40:21 -0400 Received: from sender-pp-092.zoho.com ([135.84.80.237]:25350 "EHLO sender-pp-092.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251AbeGDQkU (ORCPT ); Wed, 4 Jul 2018 12:40:20 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=from:to:cc:subject:date:message-id; b=ZMtc74Y0gZVqU/pBlnoQapt7HWwUyFG4id2Hb6OCh9zBCCV/ZE0+KnDHOPzIb2kiU/Vz4bzn3Uyr qAksFck/Ucj+9xgvBQT3w13GCabCzFyO7fvYHjeZDQHBytWLbnS8 Received: from YEHS1XR956R00D1.lenovo.com (123.120.80.137 [123.120.80.137]) by mx.zohomail.com with SMTPS id 1530722383924679.1339281655171; Wed, 4 Jul 2018 09:39:43 -0700 (PDT) From: Huaisheng Ye To: linux-nvdimm@lists.01.org, dan.j.williams@intel.com Cc: ross.zwisler@linux.intel.com, willy@infradead.org, vishal.l.verma@intel.com, dave.jiang@intel.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, viro@zeniv.linux.org.uk, martin.petersen@oracle.com, axboe@kernel.dk, gregkh@linuxfoundation.org, bart.vanassche@wdc.com, jack@suse.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, colyli@suse.de, chengnt@lenovo.com, Huaisheng Ye Subject: [PATCH v2 0/4] Assigning NULL to gfn of dax_direct_access if useless Date: Thu, 5 Jul 2018 00:38:19 +0800 Message-Id: <20180704163823.9980-1-yehs2007@zoho.com> X-Mailer: git-send-email 2.17.0.windows.1 X-ZohoMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huaisheng Ye Changes since v1 [1]: * Collect Jan's reviewed-by. * According to Dan's suggestion, update the unit test infrastructure tools/testing/nvdimm/pmem-dax.c for checking the validity of gfn. [1]: https://lkml.org/lkml/2018/7/4/81 --- Some functions within fs/dax don't need to get gfn from direct_access. Assigning NULL to gfn of dax_direct_access is more intuitive and simple than offering a useless local variable. So all direct_access need to check the validity of pointer pfn for NULL assignment. If pfn equals to NULL, it doesn't need to calculate its value. --- Huaisheng Ye (4): nvdimm/pmem: check the validity of the pointer pfn nvdimm/pmem-dax: check the validity of the pointer pfn s390/block/dcssblk: check the validity of the pointer pfn fs/dax: Assign NULL to gfn of dax_direct_access if useless drivers/nvdimm/pmem.c | 3 ++- drivers/s390/block/dcssblk.c | 3 ++- fs/dax.c | 9 +++------ tools/testing/nvdimm/pmem-dax.c | 6 ++++-- 4 files changed, 11 insertions(+), 10 deletions(-) -- 1.8.3.1