Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1018555imm; Wed, 4 Jul 2018 09:57:24 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdQT8nLyHQs4BJhT1/XEQ/X1CQi1EAjB7K+xibAT4UsZ7Aua0xZ/q152zDJ3E6pVVs5J1gR X-Received: by 2002:aa7:87d0:: with SMTP id i16-v6mr2981341pfo.82.1530723444506; Wed, 04 Jul 2018 09:57:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530723444; cv=none; d=google.com; s=arc-20160816; b=FApMKWXWhGYN617xnw8h+LOa+aDH/Rv1oXlvCYUma5b5MEreeBvQBcgUfy3sIO7z3G p5wup5Y5ZA75tX2eMlFh8k5JAGED0CNTTTfX7iaGsSbgtDfRe+FKbN+l4AInGhwC3QWt bMO5NJyUiHIhvGMelyM16jQKl4F00vy6P9z/z+1laT+478sbzGXR+zGPtF3meMW/HK7q FJkhZhdXtGvk8Hc9RurIAaouRnoCqolAkJa5oncoj9oB2rYAu9evCVfL25HTmm8LnG1F ymaRbPPJRzM0ZCymogf1HC0oojrol8kL6dUHJ6kIVaUPsv3xk6XhAWKrvcH0aeL+RVCq WsHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to :reply-to:from:date:domainkey-signature:arc-authentication-results; bh=M9kOa0/Qdw/I6wZJQ6mV5MEBtmyzikQnadsbKHoMuOI=; b=FORtbjPr8VKjW2Cu+4oMbY+5hHY0rF1D3cmjzPkzgBWjs2fSDoHI+NTxuZa54NuhwD 6/xRGSZSCmYVdfQxR4ddqm36+zsqXlKF/Jykz4K0ikdiKHvhMAINBmX3FW2bKJVa5lsk CSaL9uJfqQdmNCcEFss8+MrUqOmRpfI/wkoo52oiGSBKXN0wQ5K0VkcusRgjFPmn2o5o cydN+euL161l1zKTqIA6lBj0P4vy+e7nqWE9PMI9ITbzLQrsO/m1fYQhPdAQ4Vz9WDTm skbXp/3Lv5mtZasf2y6THbNS5WGPQT1AI+CCVN0VwrwgHHEwgqtq8gkVktQXbtspRnm1 1IxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8-v6si4042062plm.202.2018.07.04.09.57.10; Wed, 04 Jul 2018 09:57:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753211AbeGDQ4E (ORCPT + 99 others); Wed, 4 Jul 2018 12:56:04 -0400 Received: from sender-pp-092.zoho.com ([135.84.80.237]:25469 "EHLO sender-pp-092.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753170AbeGDQ4C (ORCPT ); Wed, 4 Jul 2018 12:56:02 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:reply-to:to:cc:message-id:in-reply-to:references:subject:mime-version:content-type:user-agent; b=NH/0WVHs8pl5r7c4SwmzFlzo30SkQTMHFrgv/+asfm3G+PavvDWfMPKBSjYMX+L/jPxGsysbaH8n BBfhHBImml6Znd6gVmDN9+O+U+Pw3GwCOra4zqzDEyJJbBMVWGV6 Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1530723327955366.6706706942804; Wed, 4 Jul 2018 09:55:27 -0700 (PDT) Received: from [123.120.80.137] by mail.zoho.com with HTTP;Wed, 4 Jul 2018 09:55:27 -0700 (PDT) Date: Thu, 05 Jul 2018 00:55:27 +0800 From: Huaisheng Ye Reply-To: yehs2007@zoho.com To: "\"Dan Williams\"" Cc: "\"linux-nvdimm\"" , "\"Ross Zwisler\"" , "\"Matthew Wilcox\"" , "\"Vishal L Verma\"" , "\"Dave Jiang\"" , "\"Martin Schwidefsky\"" , "\"Heiko Carstens\"" , "\"Al Viro\"" , "\"Martin K. Petersen\"" , "\"Jens Axboe\"" , "\"Greg KH\"" , "\"Bart Van Assche\"" , "\"Jan Kara\"" , "\"Linux Kernel Mailing List\"" , "\"linux-s390\"" , "\"linux-fsdevel\"" , "\"colyli\"" , "\"NingTing Cheng\"" , "\"Huaisheng Ye\"" Message-ID: <16466385fd1.ddcc3b7a51249.6994139134661160061@zoho.com> In-Reply-To: References: <20180704163823.9980-1-yehs2007@zoho.com> Subject: Re: [PATCH v2 0/4] Assigning NULL to gfn of dax_direct_access if useless MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Priority: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ---- On Thu, 05 Jul 2018 00:48:40 +0800 Dan Williams wrote ---- > On Wed, Jul 4, 2018 at 9:38 AM, Huaisheng Ye wrote: > > From: Huaisheng Ye > > > > Changes since v1 [1]: > > * Collect Jan's reviewed-by. > > * According to Dan's suggestion, update the unit test infrastructure > > tools/testing/nvdimm/pmem-dax.c for checking the validity of gfn. > > > > [1]: https://lkml.org/lkml/2018/7/4/81 > > > > --- > > > > Some functions within fs/dax don't need to get gfn from direct_access. > > Any reason you are calling it 'gfn'? I'm assuming that is a typo and > it should be 'pfn'. Oh, sorry. I made a mistake, it is a typo. I will correct it right now. --- Cheers, Huaisheng Ye