Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1037957imm; Wed, 4 Jul 2018 10:17:11 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdg8Q+t/d0i+W9nmSjZECoElSJ1Y/UCJyRFxXeBlmlQnTyGZJGl7lF37B5jjO8CnJCJUqRU X-Received: by 2002:a17:902:42e4:: with SMTP id h91-v6mr2900598pld.27.1530724631462; Wed, 04 Jul 2018 10:17:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530724631; cv=none; d=google.com; s=arc-20160816; b=G7HPQmfQ7GPCndF2gBJcVxzqTNbv5TG7lC4wC8WOZaOQ/V7HYUbV250sGxrr0ubjfY Vw8paMfgolLiEOgCxwzZ14Dk3J2OQTV0SUHE7D2duZDENgXa4Tey21/6EPc8xgfAmQHA h+zTFs4DVeKqY/UaTkMfQQOW6+cdPlWJeWnbulj12lc8j1JXRv6BGY47Kslsh2qZocPA bdRgdTuS9FaCW2DKLweS+43eQdbaLHIx389y4PdOBmLm4E5TjON75kODZF82muEqwlI8 jBzYN+vmq6ZE1BUg93+KYnP0K8TBlbRkXjFneG5IfVPrI+7n30ajwOgS8U79Z5txfZ1B /0KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=oxzA+KgKBHBxJx7P11nv5hfS8rGdc2n6GSYWgnPk84M=; b=BOUtTMpZJp0l3cMhYdKcNt4kdQB/IFZoa0Jl7vcRJ4MvjpoiG5t60SdLdAnAdeeaJ1 tIEKEhiSJOjtdE79pkjl70UgO93L5ouZqtve9Lx8B4yNZGJFqBwq2TXZCbyZRQtBy2Pq jWW9EBbchpVhYAoVjP/Hw2GOEU/xgjLyUCj4zy5hORBgHa46LBu54Dq6UvXN3e7o6AHO VC09/fsL7RIJ00T8hHhhwSn4G88n7hO+yUuputRbZdjpZdGaV0f3QjwMRWNwckwiGCGc 9o9Ejb7PDeQE5WXaapzaJZ+ktDgYVXtaYbIyA+hxUlE6DBlacdcIVkcW8St9DWWBjVO8 b+Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=E+LNJxvk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16-v6si3613871pgw.460.2018.07.04.10.16.56; Wed, 04 Jul 2018 10:17:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=E+LNJxvk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753103AbeGDRQO (ORCPT + 99 others); Wed, 4 Jul 2018 13:16:14 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:41787 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbeGDRQK (ORCPT ); Wed, 4 Jul 2018 13:16:10 -0400 Received: by mail-oi0-f68.google.com with SMTP id k12-v6so11938473oiw.8 for ; Wed, 04 Jul 2018 10:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oxzA+KgKBHBxJx7P11nv5hfS8rGdc2n6GSYWgnPk84M=; b=E+LNJxvkINdbMmCRjh6JbeqIG3lMPOJxGksKUHkxVI0iXOpEVDrXoSMuoVv/Hoynh/ cM25+f03BIZVSl9jP8P6JyyM7rns9VejemmWRsCEODU/6oTPAnST6iTYZZk0hXBmLk6k RJL7JnldwomQvHxgmMn5H9OeNlkcZmw/VzmzvW49kmUgOXWu5vc5dS0XakVGiztq9A9l a9+F4xUMl02VRnX9s6vPsNwaEnllw7DL/ejnMOHwyikLfn298mr6WhdTH5gLMmaj3oJJ i1M1GJbiyCtuxQVKAqA0Lw/vvVdNZy3Gk9faXEvINKmZqwnq7rFe+FftIkFO4XV8IzDg stvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oxzA+KgKBHBxJx7P11nv5hfS8rGdc2n6GSYWgnPk84M=; b=l0MBICh7SddiDdG16lZ5nAaTthEgoaBDoc/rWFsmHqB+jw+0L03B9YmEGnyYdGdEyS c+lPCJuuPXz7FP34h5st4cVt9yJy+EPcKoF+P7jWgIFhqUMSX7aYww6V72AsY+Ftvghv 6T//jNHpwBwKN2q9oyYRFPZE6M8tt3shYD3keKYNXsyAt0KpR/ADaZS5rLoh2sfH2jui nvLd2QDhbHRx0tyUeK5o0nz9Sj/hwTfxMZvH0104i/3THcEkFIUMp9Y5xAyz061T99q4 FGzJkVPWXpT89WhsPNEcm6p7D/IiMsz32iGDS+HYc6yBUdpGRMj9y5iHfX450WPEbROd gH5A== X-Gm-Message-State: APt69E0SSZCkgdUg4DIKBXghkTdg28XCM4iAzKEX7Iqtbujs763WjSvi CKu2Ceiy6Iz3tCHs++SOz1JBHCMptX+0onx/MT9Nuw== X-Received: by 2002:aca:3954:: with SMTP id g81-v6mr3315190oia.215.1530724569872; Wed, 04 Jul 2018 10:16:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:3495:0:0:0:0:0 with HTTP; Wed, 4 Jul 2018 10:16:09 -0700 (PDT) In-Reply-To: <16466385fd1.ddcc3b7a51249.6994139134661160061@zoho.com> References: <20180704163823.9980-1-yehs2007@zoho.com> <16466385fd1.ddcc3b7a51249.6994139134661160061@zoho.com> From: Dan Williams Date: Wed, 4 Jul 2018 10:16:09 -0700 Message-ID: Subject: Re: [PATCH v2 0/4] Assigning NULL to gfn of dax_direct_access if useless To: Huaisheng Ye Cc: linux-nvdimm , Ross Zwisler , Matthew Wilcox , Vishal L Verma , Dave Jiang , Martin Schwidefsky , Heiko Carstens , Al Viro , "Martin K. Petersen" , Jens Axboe , Greg KH , Bart Van Assche , Jan Kara , Linux Kernel Mailing List , linux-s390 , linux-fsdevel , colyli , NingTing Cheng , Huaisheng Ye Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 4, 2018 at 9:55 AM, Huaisheng Ye wrote: > > > > > ---- On Thu, 05 Jul 2018 00:48:40 +0800 Dan Williams wrote ---- > > On Wed, Jul 4, 2018 at 9:38 AM, Huaisheng Ye wrote: > > > From: Huaisheng Ye > > > > > > Changes since v1 [1]: > > > * Collect Jan's reviewed-by. > > > * According to Dan's suggestion, update the unit test infrastructure > > > tools/testing/nvdimm/pmem-dax.c for checking the validity of gfn. > > > > > > [1]: https://lkml.org/lkml/2018/7/4/81 > > > > > > --- > > > > > > Some functions within fs/dax don't need to get gfn from direct_access. > > > > Any reason you are calling it 'gfn'? I'm assuming that is a typo and > > it should be 'pfn'. > > Oh, sorry. > I made a mistake, it is a typo. I will correct it right now. Don't worry about sending a new version. I'll fix it up when I apply the series.