Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <d9bc90af283e03226bcc632e5c8bdf3b5d654b63.camel@perches.com>
Subject: Re: [PATCH] mm/memblock: replace u64 with phys_addr_t where
 appropriate
From:   Joe Perches <joe@perches.com>
To:     Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Michal Hocko <mhocko@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 04 Jul 2018 10:22:32 -0700
In-Reply-To: <20180704070305.GB4352@rapoport-lnx>
References: <1530637506-1256-1-git-send-email-rppt@linux.vnet.ibm.com>
         <20180703125722.6fd0f02b27c01f5684877354@linux-foundation.org>
         <063c785caa11b8e1c421c656b2a030d45d6eb68f.camel@perches.com>
         <20180704070305.GB4352@rapoport-lnx>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-07-04 at 10:03 +0300, Mike Rapoport wrote:
> On Tue, Jul 03, 2018 at 01:24:07PM -0700, Joe Perches wrote:
> > On Tue, 2018-07-03 at 12:57 -0700, Andrew Morton wrote:
> > > Did you see all this checkpatch noise?
> > > 
> > > : WARNING: Deprecated vsprintf pointer extension '%pF' - use %pS instead
> > > : #54: FILE: mm/memblock.c:1348:
> > > : +	memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pF\n",
> > > : +		     __func__, (u64)size, (u64)align, nid, &min_addr,
> > > : +		     &max_addr, (void *)_RET_IP_);
> > > : ...
> > 
> > %p[Ff] got deprecated by commit 04b8eb7a4ccd9ef9343e2720ccf2a5db8cfe2f67
> > 
> > I think it'd be simplest to just convert
> > all the %pF and %pf uses all at once.
> > 
> > $ git grep --name-only "%p[Ff]" | \
> >   xargs sed -i -e 's/%pF/%pS/' -e 's/%pf/%ps/'
> > 
> > and remove the appropriate Documentation bit.
> > 
> 
> Something like this:

not quite as you either need to run the command
multiple times or use

$ git grep --name-only "%p[Ff]" | \
  xargs sed -i -e 's/%pF/%pS/g' -e 's/%pf/%ps/g'