Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1046814imm; Wed, 4 Jul 2018 10:27:47 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfk39vk+BU1IvW38M/S2gQPcOB2Lo0TYzBJb3rAWoPkuuV2NtWBLETh67984NhmAmQwgvcC X-Received: by 2002:a65:608b:: with SMTP id t11-v6mr2664932pgu.259.1530725267752; Wed, 04 Jul 2018 10:27:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530725267; cv=none; d=google.com; s=arc-20160816; b=r5iMzrZTxvF+ff210+57hgo34M5Y99s1x7bKPNEJ6LY4K24GtGkMyjJuI30NuaTSDE T4OrYgqUef6YIUmmsFI6uGGOjeepzM+Yv6JcZPQA69i+vLhNaod9OWQCqZj6R1snmdEy hreSZtcPFHx8RyQjlt/a0HKlMtgylqL9+YTpFXS5PRqli9lLUKInK1ec7+7Zm5OQBfT1 CF5twOEL/wqfMA28mkj/T5t0p2jnYKp4xARMEohM3w9JtD/wfNFh7579CmoHf8fNWm8Z Wm+NrqAtXD20kNcYe7/7KPeaX/fFZfIU8Ns7lgk6KFk06b19m1uYI5et0cE5K2W0UVpa Nusw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=F5jD1LCPV9dUz7lvR+MECTsvaMA5mkaVatLORBJiTak=; b=A/D5I+RAiNp0Wzj22DuSQ+4OG01OpgoKLZ7Zc6LjwER1stuwh3O7o8cmqK3ifWcuqy pOQ8n3Re3a7iImjbH685jJt4sUu3A3BI2zm5Gi9L4U01jOZKXMTSExcOy0wlfjJ06x/k xmXrujJHUfNnKcFuq5CglRPwP3uO8JxtNSWZrP/W/Ma3NTmkCLoVjbEwEliVKBCzBEWc J0ikgDgKk/8K0jsSheqxEpY6eY1xunrGkzNyWrOjvApUGLlwF8BfNTzuv9edcu3g4LAh Eb7Hw2mSEdLCN4ifi+3WrwSnGYeyqt7jOkOPr1ogKBW+ttpJ5/m2Kq0JSAIA3T3P65lL oVVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11-v6si3559925pgp.95.2018.07.04.10.27.33; Wed, 04 Jul 2018 10:27:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbeGDR0J (ORCPT + 99 others); Wed, 4 Jul 2018 13:26:09 -0400 Received: from mga17.intel.com ([192.55.52.151]:20803 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbeGDR0I (ORCPT ); Wed, 4 Jul 2018 13:26:08 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2018 10:26:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,306,1526367600"; d="scan'208";a="72262320" Received: from saamir-mobl.ger.corp.intel.com (HELO localhost) ([10.252.34.242]) by orsmga002.jf.intel.com with ESMTP; 04 Jul 2018 10:25:59 -0700 Date: Wed, 4 Jul 2018 20:25:58 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tom Lendacky , Borislav Petkov , Konrad Rzeszutek Wilk , Greg Kroah-Hartman , Janakarajan Natarajan , David Woodhouse , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v12 03/13] x86/sgx: add SGX definitions to msr-index.h Message-ID: <20180704172558.GE6724@linux.intel.com> References: <20180703182118.15024-1-jarkko.sakkinen@linux.intel.com> <20180703182118.15024-4-jarkko.sakkinen@linux.intel.com> <296d6c54-306d-ebec-0a7a-68e06d00e704@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <296d6c54-306d-ebec-0a7a-68e06d00e704@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 03, 2018 at 11:31:59AM -0700, Dave Hansen wrote: > On 07/03/2018 11:19 AM, Jarkko Sakkinen wrote: > > --- a/arch/x86/include/asm/msr-index.h > > +++ b/arch/x86/include/asm/msr-index.h > > @@ -479,6 +479,8 @@ > > #define FEATURE_CONTROL_LOCKED (1<<0) > > #define FEATURE_CONTROL_VMXON_ENABLED_INSIDE_SMX (1<<1) > > #define FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX (1<<2) > > +#define FEATURE_CONTROL_SGX_ENABLE (1<<18) > > +#define FEATURE_CONTROL_SGX_LE_WR (1<<17) > > #define FEATURE_CONTROL_LMCE (1<<20) > > Have you run checkpatch.pl on these? There's a tabs-vs-spaces issue here. Thought I did. Do not know how that has slipped there but I will fix it. Thanks. /Jarkko