Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings
To:     Justin Skists <justin.skists@juzza.co.uk>, w.d.hubbs@gmail.com,
        gregkh@linuxfoundation.org, speakup@linux-speakup.org
Cc:     devel@driverdev.osuosl.org, chris@the-brannons.com,
        dhowells@redhat.com, linux-kernel@vger.kernel.org
References: <1530603080-1353-1-git-send-email-tsuliman@linuxvaults.com>
 <1527895743.93688.1530605455516@email.1and1.co.uk>
From:   Tamir Suliman <tsuliman@linuxvaults.com>
Message-ID: <fb7d3816-255d-15e7-b9ef-533b1167f73c@linuxvaults.com>
Date:   Wed, 4 Jul 2018 22:46:05 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1527895743.93688.1530605455516@email.1and1.co.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Interesting construct...  Yeah I'm little bit rusty on my C 
/programming  . I understand  proper coding style may be should end with 
else so I wasn't sure .. however this resolved the warnings. :)


Did you compile this?


Yes I did compile  however the only issue i found when I'm compiling is  
modules symvers missing messages researched online and found couple of 
articles that recommended  to  run full kernel build . Please bear with 
me I'm new to this and very excited about learning and contributing.


On 7/3/2018 11:10 AM, Justin Skists wrote:
>> On 03 July 2018 at 08:31 Tamir Suliman <tsuliman@linuxvaults.com> wrote:
>> +++ b/drivers/staging/speakup/keyhelp.c
>> @@ -167,7 +167,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
>>   		synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO));
>>   		build_key_data(); /* rebuild each time in case new mapping */
>>   		return 1;
>> -	} else {
>> +	} else if {
> Interesting construct...
>
>
>> @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
>>   			continue;
>>   		}
>>   
>> -		index = simple_strtoul(cp, &temp, 10);
>> +		index = simple_ktrtoul(cp, &temp, 10);
> Did you compile this?
>
>
> Justin.