Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] FBTFT: fb_sh: Fix alignment and style problems Fixed
 Coding style issues Signed-off-by: Tamir Suliman <tsuliman@linuxvaults.com>
To:     Joe Perches <joe@perches.com>, thomas.petazzoni@free-electrons.com
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org
References: <1530369159-23872-1-git-send-email-tsuliman@linuxvaults.com>
 <fc7149540b1e70e82adb0f2698da78ed65e45ffb.camel@perches.com>
From:   Tamir Suliman <tsuliman@linuxvaults.com>
Message-ID: <ed714b1b-c082-d0e8-8673-7cf9bf2dddcc@linuxvaults.com>
Date:   Wed, 4 Jul 2018 22:58:08 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <fc7149540b1e70e82adb0f2698da78ed65e45ffb.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Yes I did ..the misalignment and indentations were not intentional 
forgot to fix that but It was added to the patch.. will fix that on v 2  
my first patch still working on how to do things properly :(

On a different note , I made some changes to the function.

Thanks for your message.


On 6/30/2018 7:20 PM, Joe Perches wrote:
> On Sat, 2018-06-30 at 14:32 +0000, Tamir Suliman wrote:
>> ---
>>   drivers/staging/fbtft/fb_sh1106.c | 26 +++++++++++++-------------
>>   1 file changed, 13 insertions(+), 13 deletions(-)
> Adding to what Greg's patchbot already wrote:
>
>> diff --git a/drivers/staging/fbtft/fb_sh1106.c b/drivers/staging/fbtft/fb_sh1106.c
> []
>> @@ -36,27 +36,27 @@ static int init_display(struct fbtft_par *par)
>>   	par->fbtftops.reset(par);
>>   
>>   	/* Set Display OFF */
>> -	write_reg(par, 0xAE);
>> +		write_reg(par, 0xAE);
>
> Nope.
>
> You are overly indenting already correctly indented code.
> Statements start in the same column unless following an
> if/for/do/while/else/case.
>
>> @@ -89,8 +89,8 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
>>   
>>   static int blank(struct fbtft_par *par, bool on)
>>   {
>> -	fbtft_par_dbg(DEBUG_BLANK, par, "%s(blank=%s)\n",
>> -		      __func__, on ? "true" : "false");
>> +	fbtft_par_dbg(DEBUG_BLANK, par, "%s(_func_=%s)\n",
>> +			__func__, on ? "true" : "false");
> Again, nope.
>
> Here you are misaligning a multi-line continuation
> which is correctly aligned to the open parenthesis.
>