Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next 6/8] virtio: introduce packed ring defines
To:     Jason Wang <jasowang@redhat.com>, mst@redhat.com,
        kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     wexu@redhat.com, tiwei.bie@intel.com, jfreimann@redhat.com
References: <1530596284-4101-1-git-send-email-jasowang@redhat.com>
 <1530596284-4101-7-git-send-email-jasowang@redhat.com>
From:   Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <0f293989-a0ca-e7ad-f907-83a8d8445335@redhat.com>
Date:   Wed, 4 Jul 2018 22:15:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1530596284-4101-7-git-send-email-jasowang@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 07/03/2018 07:38 AM, Jason Wang wrote:
> diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h
> index 6d5d5fa..71c7a46 100644
> --- a/include/uapi/linux/virtio_ring.h
> +++ b/include/uapi/linux/virtio_ring.h
> @@ -43,6 +43,8 @@
>   #define VRING_DESC_F_WRITE	2
>   /* This means the buffer contains a list of buffer descriptors. */
>   #define VRING_DESC_F_INDIRECT	4
> +#define VRING_DESC_F_AVAIL      7
> +#define VRING_DESC_F_USED	15

For consistency, you may want to make VRING_DESC_F_AVAIL and 
VRING_DESC_F_USED to represent the bit mask and not the bit position,
as done for VRING_DESC_F_WRITE and VRING_DESC_F_INDIRECT.

Regards,
Maxime