Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp254315imm; Wed, 4 Jul 2018 23:03:37 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd4YYUhD4mj/StlXwSkj2UNCqha/J5u0WG3K6K02lKo2C89+r76iJsU9uxrt1QSXkuZKw+B X-Received: by 2002:a65:520c:: with SMTP id o12-v6mr4346023pgp.15.1530770617838; Wed, 04 Jul 2018 23:03:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530770617; cv=none; d=google.com; s=arc-20160816; b=lsC1cTX0TMfdTIgfov4j8lJzl1ncFMFWs9otJ3iv90i9BPEHIfaoEyHu2uyZ8iWPW1 +d9egfgeTFVlXUlQu7HKIoWlKJic4wLGgEHhj9nwImXIFDSwe3VAMcxIdoBSzNqLV0IW /4SQlYYpDDsCcH447dsxGVjH/lVDlJx4xV//DlsYKrFA5HIp2fdd2sOP03O5JeZy/9ca AkZYK9m6wEEjsPGjFE5diX5wkBFPAqthJtrQ14X6MvdR3XyNmUqvks+cfCoSTcTY8xe/ NnSzJWy1g3/tlIDQ0rguUK02OWherGOKupvRE1EYCblgIeos/4ga4mKXflKF/a7qAqcJ dFiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=R8Xi53YCmrfi2Vki8iypNfFN1CHzup3HILakUMjOC60=; b=Nin7/6C8i9+v8OCzxIzbrmFczIRBeAE5sbiCt/hYbH//qFW/sF+rzsm3oh1UHrrAr5 tp85KGIG/tn/xMyMLbmpY+NPOPp4gfMwmhORGR6LZ9XkmZa6nc0MWplUc8qDmjXo/v/x wai06FBjPnDRYjT7fhkz8gSsArQ+n0828sBn/65igBeUBpe6/L/UVL6hgmIoyQt+M0bK 52d/wcpTtDU+cnGK1ppEIyc1AfYn71hTQ2xFxEx9v9dHYgZqm27nRAZ+XBA59kvWH9As T5t5a/l4OW+VfuPZ1dN9Ci9vEU9jvcCbSbHX8Z6sfpqsekrTWXHkwBCdc+DpKbtWUkio vV9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9-v6si5024744pll.370.2018.07.04.23.03.23; Wed, 04 Jul 2018 23:03:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbeGEGCe (ORCPT + 99 others); Thu, 5 Jul 2018 02:02:34 -0400 Received: from mail1.windriver.com ([147.11.146.13]:41138 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbeGEGCc (ORCPT ); Thu, 5 Jul 2018 02:02:32 -0400 Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id w6562A7M006874 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 4 Jul 2018 23:02:11 -0700 (PDT) Received: from [128.224.155.90] (128.224.155.90) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.399.0; Wed, 4 Jul 2018 23:02:10 -0700 Subject: Re: [PATCH] tipc: mark expected switch fall-throughs To: "Gustavo A. R. Silva" , Jon Maloy , "David S. Miller" CC: , , References: <20180704211359.GA9836@embeddedor.com> From: Ying Xue Message-ID: <7c9bd75f-a3e4-79fd-b7e7-79aeb42fbb50@windriver.com> Date: Thu, 5 Jul 2018 13:57:02 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180704211359.GA9836@embeddedor.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.155.90] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/2018 05:13 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 2 was used: -Wimplicit-fallthrough=2 > > Signed-off-by: Gustavo A. R. Silva Acked-by: Ying Xue > --- > net/tipc/bearer.c | 1 + > net/tipc/link.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c > index 2dfb492..fd6d8f1 100644 > --- a/net/tipc/bearer.c > +++ b/net/tipc/bearer.c > @@ -610,6 +610,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt, > case NETDEV_CHANGE: > if (netif_carrier_ok(dev)) > break; > + /* else: fall through */ > case NETDEV_UP: > test_and_set_bit_lock(0, &b->up); > break; > diff --git a/net/tipc/link.c b/net/tipc/link.c > index 695acb7..6386032 100644 > --- a/net/tipc/link.c > +++ b/net/tipc/link.c > @@ -1063,6 +1063,7 @@ static bool tipc_data_input(struct tipc_link *l, struct sk_buff *skb, > skb_queue_tail(mc_inputq, skb); > return true; > } > + /* else: fall through */ > case CONN_MANAGER: > skb_queue_tail(inputq, skb); > return true; >