Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp294996imm; Thu, 5 Jul 2018 00:01:07 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe3kDo+OcPqP4+EID56cYuQb8YLhhUhT6/W/9n0teAHJPXOPeMVgNgnB7QBX8YVXZyeceqr X-Received: by 2002:a17:902:bccc:: with SMTP id o12-v6mr4939134pls.169.1530774067174; Thu, 05 Jul 2018 00:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530774067; cv=none; d=google.com; s=arc-20160816; b=rMRwupehzdMreEnFgPqwCoIuqDhP6/rU57IO53PTUiVs4QZPqwuC8/I8vqPvZsmhiV vTrAn5Ob7oVmoeQfQPD0anAwmqBR8/BAya4ry0D5JHdDp/IYslGoMyhDKMKjNqRhzayi 6FPu7xsXRsw4hw8ZTmfITelR0/e8/WVg8HPs04tqovgeXbfnOaGJvWz1b6WMCzLSwkBC tJZhTiJ7wHNHTwa0KuAgvdCPw6eBNfmmV9R+l7TQ9HLIYXf8xHvDs+VstfQ7ZoURifPN u8DApyJQGJ9Pa6PZYmCWQw2/HVVnnQ3VBbjj/E3NND1O0QGssM5tOrK/2j8QTpcMQWNt fZCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=WV8OiOAO0QJeJlnXTJDRuFKAp4t8wZvXCZPdn2ki4U0=; b=Cm5lh0g8UpzgNxh3ZkGpipQWVgwlyjwQC3+uc8bUSO/Dg6d75E1RJA6IAcl2IG5LG1 JhNj0nxFNXBJg6NjAxSoahLUX5Fr372aWosSScuv80MQHLJcmQ1uZlV5Z9WvqJqav1F3 aaRD+tDsEIDzlCl63JKzAUb96ty2R//1yiqryvBhWvh4iuJBc/WL9gZ4rZ7B6hxm9Kw3 c++DoD8ua0sJJI2g0SBOjC8j77IWJUqT62jg76r+Hsg6v7feLamsPx96BBf+fQszqDu/ zywpu4Nj2gBmvCeun941nHQ0HCbv7E80N3Kag8SWaZpKOV6yJf82NXfHnCyWWD1ByC0v Y9fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19-v6si5107189pgk.100.2018.07.05.00.00.53; Thu, 05 Jul 2018 00:01:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbeGEG7z convert rfc822-to-8bit (ORCPT + 99 others); Thu, 5 Jul 2018 02:59:55 -0400 Received: from mail.bootlin.com ([62.4.15.54]:40198 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753401AbeGEG7v (ORCPT ); Thu, 5 Jul 2018 02:59:51 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 8E36A207D4; Thu, 5 Jul 2018 08:59:48 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from xps13 (AAubervilliers-681-1-39-106.w90-88.abo.wanadoo.fr [90.88.158.106]) by mail.bootlin.com (Postfix) with ESMTPSA id 45388206FF; Thu, 5 Jul 2018 08:59:38 +0200 (CEST) Date: Thu, 5 Jul 2018 08:59:36 +0200 From: Miquel Raynal To: Wei Yongjun Cc: Boris Brezillon , Richard Weinberger , "David Woodhouse" , Brian Norris , Marek Vasut , Frieder Schrempf , , , Subject: Re: [PATCH -next v3] mtd: spinand: fix missing unlock on error Message-ID: <20180705085936.38f6c374@xps13> In-Reply-To: <1530696627-84879-1-git-send-email-weiyongjun1@huawei.com> References: <1530696061-76467-1-git-send-email-weiyongjun1@huawei.com> <1530696627-84879-1-git-send-email-weiyongjun1@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei, Wei Yongjun wrote on Wed, 4 Jul 2018 09:30:27 +0000: > Add the missing unlock before return from function > spinand_mtd_(read|write) in the error handling case. > > Fixes: c898e0526fb6 ("mtd: nand: Add core infrastructure to support SPI NANDs") > Signed-off-by: Wei Yongjun > --- Thanks for the two fixes over the spinand work. As this code is not yet upstream, do you mind if I fold those fixes directly with the initial patch? Thanks, Miquèl