Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp534886imm; Thu, 5 Jul 2018 04:49:11 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfCntRk9qyCQSPJUa9jiHLbeJxD1MI99/YwVtYzgqFJeI4CCuqxuXB09K1e0SE60zYInd8W X-Received: by 2002:a62:4bc6:: with SMTP id d67-v6mr5987387pfj.175.1530791351047; Thu, 05 Jul 2018 04:49:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530791351; cv=none; d=google.com; s=arc-20160816; b=Jo14vJUv1qSXshBSyR+VvCNIFCDErQ69W1q10MRSrSdpMS5vlSSYutYD8Cf9hIPdAu mNnbqfjaqv71aKX7vMA9L2TjsOYvpFk+HcjiWfGVZX8W2K/mzLitRmL2w9+bQwMgJo48 T7eDgoljny76wqxhLqadQPmpw+vb/h2y0a2uDuhVZ8y/P8cje1K7C+DF513oimcm2wmf iKi9e0NIfK0Sf8cIh0T/ZzE4g3QKKcBsPpF9qCUumIs2ms/BqsqpUc9uMKTp52QCDQ/U 77SCwl624wyDI3bXuxpmlGvCKbNgjZ8wqie4NraRXAQe7j3A9U50/Qot9JyOEp31fbRn sI9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=BIXOHERpaJEyyYNa3f6TWyx9F1E4nb9qNplrZ1hoZ3U=; b=WTe2R63IYYzxEM1hTQf8q1MFVUZgLmr0BpL1lSVIeEQ57/Wt21DtedHU+i+KqoggLU 1WqYYtqIcf+w3NoW9VHay/qt7q1uYp785L/XPzOhksonhAIYqVutbPiNrCTbAZkQf9G3 IipkPZEMTcsMdFxWDWQyOvU0iDD47lw14AneFE6uG8mN9zNxlYN7O+67blX7AILtB0Lj Q6HZvxN6UntaBTmyTznUtPPq0k3ZmTHJWYxIezW7TJb1EDSl0nzN6iJlVx2JXKNWqnsc UZZxjQJe2zNAMJ6OAlSbjJahcWutkKc59+INeafYNG3M87pPpQpGY8xcl7y1G5ohyIsk U1jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=LgWaGBSO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u184-v6si5561020pgd.193.2018.07.05.04.48.56; Thu, 05 Jul 2018 04:49:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=LgWaGBSO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982AbeGELrZ (ORCPT + 99 others); Thu, 5 Jul 2018 07:47:25 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:37266 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753921AbeGELrY (ORCPT ); Thu, 5 Jul 2018 07:47:24 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w65Bidki096612; Thu, 5 Jul 2018 11:46:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2017-10-26; bh=BIXOHERpaJEyyYNa3f6TWyx9F1E4nb9qNplrZ1hoZ3U=; b=LgWaGBSOd3OgU3lGW0kYgWNhwtQFKuLb3LShTnI9IcLXDoow9HlEk7d7b+VnvQjtfwjr jD6t42NUB8uBbsJICFj7OPUq6MI4cCP/Gh9ZEHs1Xz0/zumLqNvkDNkjBXvrZq82os4+ ndAUmV0RJVUKdpgAo/RTsEGIOCVMktqgkLkAhRQavR7GTOMSYgsTxzNbJeJjkuG5tpZi B/pDKbqd8PTYB95xeyV8cUAtIUrFh4d6eVt9ArGI6nZ5MPjOfk15gIol5syM2qe1QdH8 SbrFZ8YNDZABrAiOv56amXoFKWoo2NB8X/vohBuRoLhryGTL0NP+me7qj17hbxBrgEiY Zw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2k0dnjnhgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Jul 2018 11:46:16 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w65BkFFa019163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Jul 2018 11:46:15 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w65BkCtw024147; Thu, 5 Jul 2018 11:46:12 GMT Received: from mwanda (/197.157.34.168) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Jul 2018 04:46:11 -0700 Date: Thu, 5 Jul 2018 14:46:00 +0300 From: Dan Carpenter To: Tamir Suliman Cc: Justin Skists , w.d.hubbs@gmail.com, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, dhowells@redhat.com, linux-kernel@vger.kernel.org, chris@the-brannons.com Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings Message-ID: <20180705114600.f27xfsro3yucorrt@mwanda> References: <1530603080-1353-1-git-send-email-tsuliman@linuxvaults.com> <1527895743.93688.1530605455516@email.1and1.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8944 signatures=668704 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=677 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807050138 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 04, 2018 at 10:46:05PM +0300, Tamir Suliman wrote: > > Interesting construct...? Yeah I'm little bit rusty on my C /programming? . > I understand? proper coding style may be should end with else so I wasn't > sure .. however this resolved the warnings. :) The code you wrote was very wrong. It doesn't compile. You need to figure out what is wrong with your testing so that it doesn't happen again. regards, dan carpenter