Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Jul 2018 14:55:49 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Justin Skists <justin.skists@juzza.co.uk>
Cc:     w.d.hubbs@gmail.com, gregkh@linuxfoundation.org,
        speakup@linux-speakup.org,
        Tamir Suliman <tsuliman@linuxvaults.com>,
        devel@driverdev.osuosl.org, dhowells@redhat.com,
        linux-kernel@vger.kernel.org, chris@the-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings
Message-ID: <20180705115549.wifgpi5qe6dfkcoj@mwanda>
References: <1530603080-1353-1-git-send-email-tsuliman@linuxvaults.com>
 <1527895743.93688.1530605455516@email.1and1.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1527895743.93688.1530605455516@email.1and1.co.uk>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 03, 2018 at 09:10:55AM +0100, Justin Skists wrote:
> > @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
> >  			continue;
> >  		}
> >  
> > -		index = simple_strtoul(cp, &temp, 10);
> > +		index = simple_ktrtoul(cp, &temp, 10);
> 
> Did you compile this?

Try to avoid rhetorical questions.  Just say "This doesn't compile.  Be
more careful."

regards,
dan carpenter