Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp572462imm; Thu, 5 Jul 2018 05:26:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcfmpQBbhpu3yfTqpG8qbWRQhFUJOq69ZhfI7YhqEc//sMaiTTVAU8k27szdgwjNPWTFOT3 X-Received: by 2002:a17:902:201:: with SMTP id 1-v6mr6090851plc.310.1530793619351; Thu, 05 Jul 2018 05:26:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530793619; cv=none; d=google.com; s=arc-20160816; b=b0G5GnEYUehyt8UdiTRu+Y6nEqMNqZoVMM0hf6oN5JKZO54qTldnQiWYqUk+7dOu5r lTjLjt4xhnSeGOUX8RiiB3DvHJ9i8FuFENN7+vtMLfy4whjbwu2/dL1PE/5mgxth9p0z fR7uLNbUvI9RJF2/sVRAzx03QSoblxUs8HQr9TW78lDLCYE1zbBz9lR5QhUMRudbf7qS xvgDnzC3xeu6icB/N6/POAIuES+Iv78TMS9EGIgBVAsVXPxrizBCguACgLxKW8xbpHMS Ow9ssba4cU5dzUYg1mINmFGS3O60aGLgIWdmadlP6esRU5okpbZPdEkt3kIs6P2w9XZP tUeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dkim-signature:arc-authentication-results; bh=2/STsKoK7PqJAw7UkX4x7VNwrHz80BdwqqvgORA3Trk=; b=pHIyyScxq/5BiPMg9ZjMq8Xz8m/HvXhghEf23n7TWq+yFIi+0dXfiWbCclZwSgxx0C nqIVNnhhisDGJh5Fgnig7GAwAhfj1ixj4af24Bc8I0RGfCgmKZueglYMHKfHnlXxmPjy Os+NONHrMEXzbeQskzGUQEZQI6kPxZrxODjC8SDKHOEfaBrREX5VI5u/hPFhVwP95ffV g9Olv0TL+2m2w7iIKuDZPEZ74QIpT0CW8AbGjvBpV9V0dt+9Y11BU1s73wt6OgL9g+Ea yEfQJK4TjxqwsEZT8Lo68lIhNcMbmGBmp2KUtmkAaRahNtTYqiG6OchitvB6YLj8XYlh 0cSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=t61CcM4F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si5240039pgd.509.2018.07.05.05.26.44; Thu, 05 Jul 2018 05:26:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=t61CcM4F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbeGEMYk (ORCPT + 99 others); Thu, 5 Jul 2018 08:24:40 -0400 Received: from mail-ua0-f196.google.com ([209.85.217.196]:38708 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbeGEMYj (ORCPT ); Thu, 5 Jul 2018 08:24:39 -0400 Received: by mail-ua0-f196.google.com with SMTP id 59-v6so5281064uas.5 for ; Thu, 05 Jul 2018 05:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2/STsKoK7PqJAw7UkX4x7VNwrHz80BdwqqvgORA3Trk=; b=t61CcM4F884buLMKby0OcBspy4GLhmh3t7pIIGudRbljgXhUVzDWmAwMflUIeerJAL QE4lQ9Eo0FFB+dyaAn8LzHFbATXLHreAkjD7wMpvaskenvAaOoTZL5B3Ub17FrVjyTvV mniDDiTazI2+Gd2ZTwT85fpuiETEaAXlPhWB+NzQM55KbZ0ja3ANlJR7Navwy8RO3ORE 783u/LJP+e23Xpbyh9mQs8DnhdGuvVdJnb8I2YzCl7NYQAn5SGDX2OJ/xm9yAK7P0/T5 VEJqQqfk2uwC0iRGhqTa8MRc5T1W/X+SYHqZIiM8dmxsYeD9egEDdwECO7rK24Uld65n ZjZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2/STsKoK7PqJAw7UkX4x7VNwrHz80BdwqqvgORA3Trk=; b=o7ojos6BiWFgJfzNoj8VF2pHIB2EODQsAyL2K8SRNG1vvlGDYr5S2i1W8pIHvBlgIk KCVtwZcdOTE0MOCbLtjZ0kROfp3omV/JztWN1xBcFOvnBFAI6+TGdz79pNXFRgHKtgoV x590cxmygvzZjB7AOgSve6IgF3Qqwbd8Lpt17wJT6OIsqS9oMGC/aWZEZ/hVmGPF11ge zZ+In/S7LNC+EHkvjEnPiDVK78Q/FvF+OTS0yYHWno/Jo/nBE5KcGZ3rFJlnANEZ5cjS 3J4KMT8fWE9KCoubTiUJSoR/VJaiNFeSrTbxtrGZl34EouzWKgPgewP3pwXLSX1XsqNG EvNA== X-Gm-Message-State: APt69E1LZtZzQNumavpaU0ZVp44J/Owajzks7qMc885wmzEH//toPca+ QLVwgb3HSjKzYHzMH9P083R3li2yHPHmq5m727Q= X-Received: by 2002:ab0:1a23:: with SMTP id a35-v6mr3451392uai.47.1530793478102; Thu, 05 Jul 2018 05:24:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:2149:0:0:0:0:0 with HTTP; Thu, 5 Jul 2018 05:24:37 -0700 (PDT) In-Reply-To: References: <1530376739-20459-1-git-send-email-ufo19890607@gmail.com> <20180704081710.GH22503@dhcp22.suse.cz> From: Andy Shevchenko Date: Thu, 5 Jul 2018 15:24:37 +0300 Message-ID: Subject: Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header To: =?UTF-8?B?56a56Iif6ZSu?= Cc: mhocko@kernel.org, Andrew Morton , David Rientjes , "Kirill A. Shutemov" , aarcange@redhat.com, Tetsuo Handa , guro@fb.com, yang.s@alibaba-inc.com, linux-mm , Linux Kernel Mailing List , Wind Yu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 5, 2018 at 2:23 PM, =E7=A6=B9=E8=88=9F=E9=94=AE wrote: > Hi Michal and Andy > The enum oom_constraint will be added in the struct oom_control. So > I still think I should define it in oom.h. You missed the point. I'm talking about an array of string literals. Please, check what the warning I got from the compiler. > Michal Hocko =E4=BA=8E2018=E5=B9=B47=E6=9C=884=E6=97= =A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=884:17=E5=86=99=E9=81=93=EF=BC=9A >> >> On Wed 04-07-18 10:25:30, =E7=A6=B9=E8=88=9F=E9=94=AE wrote: >> > Hi Andy >> > The const char array need to be used by the new func >> > mem_cgroup_print_oom_context and some funcs in oom_kill.c in the >> > second patch. >> >> Just declare it in oom.h and define in oom.c >> -- >> Michal Hocko >> SUSE Labs --=20 With Best Regards, Andy Shevchenko