Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CA+ZOyahLiGS-7DQO8ncJ_=w-Mkav33FBBOC9-K08XSyhPgjtGg@mail.gmail.com>
 <mhng-640c8a78-7e3a-4ccf-9951-fc85a0969b9c@palmer-si-x1c4>
In-Reply-To: <mhng-640c8a78-7e3a-4ccf-9951-fc85a0969b9c@palmer-si-x1c4>
From:   Zong Li <zongbox@gmail.com>
Date:   Thu, 5 Jul 2018 21:33:07 +0800
Message-ID: <CA+ZOyaggr-Y2-Yh_o4+XQLoT5-o6PM9m4_T3sHHUq13+CgJYEQ@mail.gmail.com>
Subject: Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index
 and type for 32-bit
To:     Palmer Dabbelt <palmer@sifive.com>
Cc:     hch@infradead.org, Zong Li <zong@andestech.com>,
        linux-riscv@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        greentime@andestech.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Palmer Dabbelt <palmer@sifive.com> =E6=96=BC 2018=E5=B9=B47=E6=9C=885=E6=97=
=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=884:58=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Fri, 29 Jun 2018 09:53:49 PDT (-0700), zongbox@gmail.com wrote:
> > Christoph Hellwig <hch@infradead.org> =E6=96=BC 2018=E5=B9=B46=E6=9C=88=
29=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=883:12=E5=AF=AB=E9=81=93=EF=
=BC=9A
> >>
> >> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote:
> >> > Use generic marco to get the index and type of symbol.
> >>
> >> Why do we even need this in a uapi header?  Shouldn't ELF_RISCV_R_SYM
> >> and ELF_RISCV_R_TYPE move to module.c?  In that case we could just
> >> use CONFIG_64BIT.
> >
> > Make sense. I even think the all definitions can be move to include/asm=
/elf.h.
> > How do you think about that?
>
> Sorry I've been slow about reviewing this, but I think just in the intere=
st of
> getting a sane RV32I port up and running quickly (so we can try to get gl=
ibc in
> shape) I'm going to take this for now.
>
> Do you mind submitting a cleanup patch?

I will send a patch to clean up. Thanks everyone to review this patchset.