Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Jul 2018 18:33:38 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     xiubli@redhat.com
Cc:     linux-kernel@vger.kernel.org, pkalever@redhat.com,
        pkarampu@redhat.com, atumball@redhat.com, sabose@redhat.com,
        mchristi@redhat.com
Subject: Re: [PATCH 1/2] uio: change to use the mutex lock instead of the
 spin lock
Message-ID: <20180705163338.GA14941@kroah.com>
References: <1530808048-9494-1-git-send-email-xiubli@redhat.com>
 <1530808048-9494-2-git-send-email-xiubli@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1530808048-9494-2-git-send-email-xiubli@redhat.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 05, 2018 at 12:27:27PM -0400, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> We are hitting a regression with the following commit:
> 
> commit a93e7b331568227500186a465fee3c2cb5dffd1f
> Author: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
> Date:   Mon May 14 13:32:23 2018 +1200
> 
>     uio: Prevent device destruction while fds are open
> 
> The problem is the addition of spin_lock_irqsave in uio_write. This
> leads to hitting  uio_write -> copy_from_user -> _copy_from_user ->
> might_fault and the logs filling up with sleeping warnings.
> 
> I also noticed some uio drivers allocate memory, sleep, grab mutexes
> from callouts like open() and release and uio is now doing
> spin_lock_irqsave while calling them.
> 
> Reported-by: Mike Christie <mchristi@redhat.com>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  drivers/uio/uio.c          | 33 ++++++++++++++-------------------
>  include/linux/uio_driver.h |  2 +-
>  2 files changed, 15 insertions(+), 20 deletions(-)

Any specific reason you did not also cc: the author of the above patch
to review this one?

Please fix up and resend.

greg k-h