Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp899116imm; Thu, 5 Jul 2018 10:51:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc9G32knn/EenRnkuUqyrDghs2ETWeGQbiiDIf1QXC8/nUJ0ZKPd0c2xWAQDlnXUtaGeuyx X-Received: by 2002:a62:2ad1:: with SMTP id q200-v6mr7482379pfq.70.1530813072167; Thu, 05 Jul 2018 10:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530813072; cv=none; d=google.com; s=arc-20160816; b=JWw18EWvCl0nKsQ51r9YMBGNM9dWUeu3Z9U0DZUPaMJSqf8hAAAY27uitCvvNQzVYq 1BpdvK2Exgu4CFGnv6KQymsSGeA++oRDbYrkz9z+xovFakm+k3y9AdeT427Cg2WKoZ8d 1AZu0rTU4wkWLbAgJZstRYjSRzOmfuAJ7UCufUH3EmgU1w1XlWD3rMFBkawO7GEKaz1t VpWpiKSzONfvZmSvzYtgIx/2NyhYtPtFcn3/e+37pZXerLjcshqEkNJEpOa7d6q5G/de wQkq0Wlp+FU80tx7XtOhwO5YoTAJi8a5WksHNLMSVuUdbd197FlU6+WC/+URohSi8/T5 nJcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=HrI1fzElgphA1CoiSKN2fMUzJjiIC7pCwytKlQi2TbI=; b=hftcPm5zdkHe/vI1x3gFjagFpmqo76VaLCPAMe+Ywa3/frrzK/5qREkeNAwFGL8fiN hIAMzNZzv/0+pD4ID7exVaMxs39Lmbb8kCNOq4VAo1SbVNG1JztdsB8XSNh7+hdIzq9C JVxELQwA46tV2S+5jEksQ8OshfyM1JGIPO2nFwpMBfwQwf+w74ArT8Am4c+N1dI+LuHD Cs20FnwaiJkzsbRA+c92s45ms2saC6l3MPcSGZc93d1xl0PQlQ0rtTgoFYUTGae2roG9 r2zT9YfA3rIwSjozZRwE6OUYfFVMGFY3DnTV05kMcTUHJr0FykE7GiMmIS9C6wLOYBNE at0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uZeVnOhI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i66-v6si6870712pfb.149.2018.07.05.10.50.57; Thu, 05 Jul 2018 10:51:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uZeVnOhI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849AbeGERtU (ORCPT + 99 others); Thu, 5 Jul 2018 13:49:20 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37840 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbeGERtS (ORCPT ); Thu, 5 Jul 2018 13:49:18 -0400 Received: by mail-pg1-f196.google.com with SMTP id n15-v6so82663pgv.4; Thu, 05 Jul 2018 10:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HrI1fzElgphA1CoiSKN2fMUzJjiIC7pCwytKlQi2TbI=; b=uZeVnOhI04Q+RUImbE73BGz02HAb08zw8Kvwy8RWtQ8A+RAA1l4HU7EQC+3hlY//Nt uKsd1pGAH6M/+GKvX6khQQVCKv/CU6yztkYj1xgm+6679fUP8hpD9/CDgAsDpjD/SkAz EES2hpCGzIywjaDnJ/aJg8EKyBIQh8K50rCc81jbyeiBV57w+bz2gFAyKclnDYq5h/DK 0WUUWY5hMnrrly6fJgUHnu/kzKGV0Ezmt/xThT7rP4HgvJeR1vIGOwRaqSO12QjhSmRz AHJUP99RXPhvzP9pNOtCS6/SF2fvNCrGrSwwGhDcRwj0BtnTScaLOrjnp3LPW0ww7xLE JPQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HrI1fzElgphA1CoiSKN2fMUzJjiIC7pCwytKlQi2TbI=; b=TeGSJsZTv6nUyAHIjP8GNeUpCpZLlWZA6Jj/0FS7NcGWB8SHiBjQaOnxtzHGxHvQth aBqXxqq5TcZKjS+je/eGYRzAZGFLmcRD/EKBPGMztXrmom1SFgqxZgkh1+QuV9koSkj7 vSyD9rVPBclHk+BYDrGYCum2Gve+SeA++xS/MfYsJjsn1aigM/tfY5z/Ciur1jTDTZWL mcCre0KaEF+lN9Kq7H84fcn0CIrDM2bu3hIWc1CtdvJQXZbsJkCjp2QU/7qwFKbGvrnH JKeG//kP4s8VT0kMXsap5M0PkiMjpADr2ue4aUbSL3df07Q1T3mZDuw4fBjihygjYiPm ndJQ== X-Gm-Message-State: APt69E2bIt50jBq8pJD1y7EKRSVWwg+WDbnvEcB5c0qxrz7490GsAlya dBABDuFh+h8ZaJWXVajCWrY= X-Received: by 2002:a62:d39b:: with SMTP id z27-v6mr7531926pfk.182.1530812958032; Thu, 05 Jul 2018 10:49:18 -0700 (PDT) Received: from [10.111.67.248] (rap-us.hgst.com. [199.255.44.250]) by smtp.gmail.com with ESMTPSA id a11-v6sm1143444pfl.66.2018.07.05.10.49.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 10:49:17 -0700 (PDT) Subject: Re: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define To: Dave Carroll , Johannes Thumshirn , "Martin K . Petersen" Cc: Linux Kernel Mailinglist , Linux SCSI Mailinglist , Raghava Aditya Renukunta References: <20180705110140.19545-1-jthumshirn@suse.de> <20180705110140.19545-2-jthumshirn@suse.de> <4cd9a8cb64dc4d8aa1e10c3b008c3ba0@microsemi.com> From: Bart Van Assche Message-ID: Date: Thu, 5 Jul 2018 10:49:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <4cd9a8cb64dc4d8aa1e10c3b008c3ba0@microsemi.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/18 10:42, Dave Carroll wrote: >> Remove the AAC_STAT_GOOD definition and open code it in the places it was >> used. >> >> This will make subsequent refactoring in this area easier. >> > Please don't ... the definition itself was added to make refactoring easier. That's a vague statement. Which kind of refactoring do you plan to make? Bart.