Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 05 Jul 2018 14:50:05 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <20180705200912.GA10701@linux.intel.com>
References: <20180703182118.15024-1-jarkko.sakkinen@linux.intel.com> <20180703182118.15024-6-jarkko.sakkinen@linux.intel.com> <f9fe78ca-0ff4-814c-3681-a2366be01337@intel.com> <20180705200912.GA10701@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH v12 05/13] x86/sgx: architectural structures
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>
CC:     x86@kernel.org, platform-driver-x86@vger.kernel.org,
        sean.j.christopherson@intel.com, nhorman@redhat.com,
        npmccallum@redhat.com, linux-sgx@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>
From:   hpa@zytor.com
Message-ID: <E666884A-3EED-426E-BAB1-FA23C57BA5B9@zytor.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On July 5, 2018 1:09:12 PM PDT, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
>On Thu, Jul 05, 2018 at 08:31:42AM -0700, Dave Hansen wrote:
>> On 07/03/2018 11:19 AM, Jarkko Sakkinen wrote:
>> > +struct sgx_secs {
>> > +	uint64_t size;
>> > +	uint64_t base;
>> > +	uint32_t ssaframesize;
>> > +	uint32_t miscselect;
>> > +	uint8_t reserved1[SGX_SECS_RESERVED1_SIZE];
>> > +	uint64_t attributes;
>> > +	uint64_t xfrm;
>> > +	uint32_t mrenclave[8];
>> > +	uint8_t reserved2[SGX_SECS_RESERVED2_SIZE];
>> > +	uint32_t mrsigner[8];
>> > +	uint8_t	reserved3[SGX_SECS_RESERVED3_SIZE];
>> > +	uint16_t isvvprodid;
>> > +	uint16_t isvsvn;
>> > +	uint8_t reserved4[SGX_SECS_RESERVED4_SIZE];
>> > +} __packed __aligned(4096);
>> 
>> Why are the uint* versions in use here?  Those are for userspace ABI,
>> but this is entirely for in-kernel-use, right?
>> 
>> We've used u8/16/32/64 in arch code in a bunch of places.  They're at
>> least a bit more compact and easier to read.  It's this:
>> 
>> 	u8	foo;
>> 	u64	bar;
>> 
>> vs. this:
>> 
>> 	uint8_t	 foo;
>> 	uint64_t bar;
>
>The reason was that with in-kernel LE these were in fact used by
>user space code. Now they can be changed to those that you
>suggested.
>
>/Jarkko

For things exported to user space use __u* and __s* types... the _t types would actually violate the C standard with respect to namespace pollution.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.