Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1428155imm; Thu, 5 Jul 2018 23:16:09 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc9RVwFGK4S9zMbPxbTka0fZ37T9mpacsRhamZrv5eWBsEHzXlRRCuGove/JeQlKkLlLm+9 X-Received: by 2002:a63:8c5:: with SMTP id 188-v6mr8109277pgi.97.1530857769023; Thu, 05 Jul 2018 23:16:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530857768; cv=none; d=google.com; s=arc-20160816; b=ouIcqzIeB5Du2BF0HwXflD5jj2h8WJBbvHUySlAT8/0ujmp8mkzuKZiUITEsua4gu/ e4HOvWW1HgJLQ2mJh86DywoHcd5oFkzti2g5Z/cAomokdsZubfeBqfLEH0a4BsvZj4Y6 8qO6R6ONgGdYD+Q7r19gnikO8A9Nf+kSbFLa1hBcwuPrJrs/9Ecf/NlNelSvo+Gru0fx uhNoO3WBItxI9aUfTmkTseM3xOjYbNuzKww4DmrsUotoCt+3n3AQYh7EzZ3Pia2qtQBf ty0fzZ79wmA+BPW5c663YWZ3AimM/JgiyOgl8uRVpig8gSgLF6QwCmp67XULdzLQx9QA lYYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=aYNbaKFRTXOJ2k8BvWx9qrNWnGJXIkz4suReRdqEWJI=; b=X+qGJ4Wd7VKB2GR/XyH+XWHPm/ZcGtRX+M5f/+ujReKZXm/zSPQauaacGmLTLTHNT0 kyV5/0Asfs1Da/D9n2p2HITf7r+FYJ8+g9GzQrfao2Fsq5h70IIwohDnlT4USDNAtpCY O6/KNs6RcKtvnBZRXV5UfneQ1xKMO+YxaRaqgiYfyShknK5Zn+2yJMbbQNWc402qMDRn PT/ZDgHrYG6Nk5Iv6P9/4pnlfdQlDJ31z0xaCPDjkXyJ8XqX6EFDGo1ut0xeZ+cS5bK0 Qq9DWU5npQUPXEE1Fpht5FnV6yqX82ldAwNw6+ItgYytBhnDKs8v60JjSXnIiYQqu4uJ NwoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23-v6si7978654pfl.122.2018.07.05.23.15.54; Thu, 05 Jul 2018 23:16:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932665AbeGFFrY (ORCPT + 99 others); Fri, 6 Jul 2018 01:47:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58506 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbeGFFrV (ORCPT ); Fri, 6 Jul 2018 01:47:21 -0400 Received: from localhost (D57D388D.static.ziggozakelijk.nl [213.125.56.141]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 9364C86A; Fri, 6 Jul 2018 05:47:20 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Houston Yaroschoff , Oliver Neukum Subject: [PATCH 4.17 01/46] usb: cdc_acm: Add quirk for Uniden UBC125 scanner Date: Fri, 6 Jul 2018 07:46:22 +0200 Message-Id: <20180706054524.670321998@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180706054524.595521988@linuxfoundation.org> References: <20180706054524.595521988@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Houston Yaroschoff commit 4a762569a2722b8a48066c7bacf0e1dc67d17fa1 upstream. Uniden UBC125 radio scanner has USB interface which fails to work with cdc_acm driver: usb 1-1.5: new full-speed USB device number 4 using xhci_hcd cdc_acm 1-1.5:1.0: Zero length descriptor references cdc_acm: probe of 1-1.5:1.0 failed with error -22 Adding the NO_UNION_NORMAL quirk for the device fixes the issue: usb 1-4: new full-speed USB device number 15 using xhci_hcd usb 1-4: New USB device found, idVendor=1965, idProduct=0018 usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 1-4: Product: UBC125XLT usb 1-4: Manufacturer: Uniden Corp. usb 1-4: SerialNumber: 0001 cdc_acm 1-4:1.0: ttyACM0: USB ACM device `lsusb -v` of the device: Bus 001 Device 015: ID 1965:0018 Uniden Corporation Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 2 Communications bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 idVendor 0x1965 Uniden Corporation idProduct 0x0018 bcdDevice 0.01 iManufacturer 1 Uniden Corp. iProduct 2 UBC125XLT iSerial 3 0001 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 48 bNumInterfaces 2 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 500mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass 2 Communications bInterfaceSubClass 2 Abstract (modem) bInterfaceProtocol 0 None iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x87 EP 7 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0008 1x 8 bytes bInterval 10 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 10 CDC Data bInterfaceSubClass 0 Unused bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Device Status: 0x0000 (Bus Powered) Signed-off-by: Houston Yaroschoff Cc: stable Acked-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1758,6 +1758,9 @@ static const struct usb_device_id acm_id { USB_DEVICE(0x11ca, 0x0201), /* VeriFone Mx870 Gadget Serial */ .driver_info = SINGLE_RX_URB, }, + { USB_DEVICE(0x1965, 0x0018), /* Uniden UBC125XLT */ + .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ + }, { USB_DEVICE(0x22b8, 0x7000), /* Motorola Q Phone */ .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ },