Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1530271355-5608-1-git-send-email-yannick.fertre@st.com>
References: <1530271355-5608-1-git-send-email-yannick.fertre@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Fri, 6 Jul 2018 10:22:43 +0200
Message-ID: <CA+M3ks5GNf6i_mFqFEganGJ7-3nY+OxGwxzX1UYbT1dkv8WtMg@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: ltdc: rework reset sequence
To:     Yannick Fertre <yannick.fertre@st.com>
Cc:     Philippe Cornu <philippe.cornu@st.com>,
        Vincent Abriou <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-06-29 13:22 GMT+02:00 Yannick Fertre <yannick.fertre@st.com>:
> Reset must be properly assert before deassert.
> This is important if there is an early boot splash screen
> before the kernel start up.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>

Applied on drm-misc-next.
Thansk,
Benjamin

> ---
>  drivers/gpu/drm/stm/ltdc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 96d20c2..8f4606d 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev)
>                 }
>         }
>
> -       if (!IS_ERR(rstc))
> +       if (!IS_ERR(rstc)) {
> +               reset_control_assert(rstc);
> +               usleep_range(10, 20);
>                 reset_control_deassert(rstc);
> +       }
>
>         /* Disable interrupts */
>         reg_clear(ldev->regs, LTDC_IER,
> --
> 1.9.1
>