Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 6 Jul 2018 11:14:29 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>, mingo@kernel.org,
        linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
        juri.lelli@redhat.com, dietmar.eggemann@arm.com,
        Morten.Rasmussen@arm.com, valentin.schneider@arm.com,
        patrick.bellasi@arm.com, joel@joelfernandes.org,
        daniel.lezcano@linaro.org, quentin.perret@arm.com,
        luca.abeni@santannapisa.it, claudio@evidence.eu.com,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 07/11] cpufreq/schedutil: take into account interrupt
Message-ID: <20180706091429.GJ2494@hirez.programming.kicks-ass.net>
References: <1530200714-4504-1-git-send-email-vincent.guittot@linaro.org>
 <1530200714-4504-8-git-send-email-vincent.guittot@linaro.org>
 <20180706060033.rcgzfs6pouqssiqh@vireshk-i7>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180706060033.rcgzfs6pouqssiqh@vireshk-i7>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 06, 2018 at 11:30:33AM +0530, Viresh Kumar wrote:
> On 28-06-18, 17:45, Vincent Guittot wrote:
> > The time spent under interrupt can be significant but it is not reflected
> > in the utilization of CPU when deciding to choose an OPP. Now that we have
> > access to this metric, schedutil can take it into account when selecting
> > the OPP for a CPU.
> > rqs utilization don't see the time spend under interrupt context and report
> > their value in the normal context time window. We need to compensate this when
> > adding interrupt utilization
> > 
> > The CPU utilization is :
> >   irq util_avg + (1 - irq util_avg / max capacity ) * /Sum rq util_avg
> > 
> > A test with iperf on hikey (octo arm64) gives:
> > iperf -c server_address -r -t 5
> > 
> > w/o patch		w/ patch
> > Tx 276 Mbits/sec        304 Mbits/sec +10%
> > Rx 299 Mbits/sec        328 Mbits/sec +09%
> > 
> > 8 iterations
> > stdev is lower than 1%
> > Only WFI idle state is enable (shallowest diel state)

Also s/diel/idle/

> > +	/*
> > +	 * Interrupt time is not seen by rqs utilization nso we can compare
> 
>                                                          nso ?
> 
> > +	 * them with the CPU capacity
> > +	 */

Already fixed ;-)