Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1564178imm; Fri, 6 Jul 2018 02:23:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfLGDe49RvPKid3mB4HCJWDHlzbv4NzXlF4gnUw1E3quMNTAAQmWyZp8iPng3nKbdpfYnBy X-Received: by 2002:a63:4386:: with SMTP id q128-v6mr8711960pga.353.1530868985759; Fri, 06 Jul 2018 02:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530868985; cv=none; d=google.com; s=arc-20160816; b=yKANNwkszy/IENul8LHrRZzThFEEUFQJJpZ0qx85788MMOqNjfN2QTl2H9Vn10fSnU dMP3cuZ0xwzsN1LK3vfRx4zINWlbC60cdZRvLHJgmH6ez50ulSKJKa7+Fpl/5zE3bsLU 6DqiOJ08tQQ0+D5T664I+Tfy877XSg0Ie6VaCfJSTKv0T+QvJAtTr7Tuu0cdk7V0k7QZ B6pKNqV55mZx71ixUVy/8eFvwjEziviQ+s0EF3omZ2qwOkjVe0Or4NfN3wYIES5EB1vg pZzcFPSYj87mYKY5R8ox4txbPzvXYyoYv6o/mSj2Th7HYaBe0TQ+JC5xO+apMFOCH7sl GcsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=1f+PgkBtW/YzSKnDviQQApvrh9gaDTcnBFYiCyiykQ0=; b=F3gPogjsfftKrl/MVXFXzRtDgp2Bx32HXUNGpTRZimGJeJfj6dXaB+ehQC6TtXT6O5 4MIfo3O7TDrAJjqHYmLu+hRfNvfsWsT9Keh1pF/vtSc4O5tBMAqeivBgwwOG1TOCyoRw 9rBzd/PypOL35aGZ+cPayIWt6+4csVpDfnXZn1/Liq6CIoEVyAJ8RSLZQZW+5c1MuLUM 7VKahMmiJDB0ONUJsvSwOOMzKAsrSuiSKd2buVjzr1JLsoOVrVYAcAg4biz7BGBGEr0U 34U2aDByaUvijS7K/+7JLmUmpW2hPngZRVUqoNAVI4xPYjp0JZDP1oj828eT/mtgZXIL vrYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XZjALGOV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6-v6si7980095pfv.278.2018.07.06.02.22.50; Fri, 06 Jul 2018 02:23:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XZjALGOV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbeGFJWE (ORCPT + 99 others); Fri, 6 Jul 2018 05:22:04 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:34390 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbeGFJWC (ORCPT ); Fri, 6 Jul 2018 05:22:02 -0400 Received: by mail-it0-f68.google.com with SMTP id d191-v6so4717976ite.1 for ; Fri, 06 Jul 2018 02:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1f+PgkBtW/YzSKnDviQQApvrh9gaDTcnBFYiCyiykQ0=; b=XZjALGOVW/eoOxMmOb8H7Mkw9veqLQtj6DHy4MV3whpWxYR+5GuSrdlJkEnOPIdWL1 jPINkhWmTqO8qd8bbm3EG+GY/7pS3VscOqMlA4l1hl/z3OEpfDuNPBZSYdIxJ1u9QlWI 3v3Bxo9cSz2Kae5d88MJaM6m3xjykux2/4qWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1f+PgkBtW/YzSKnDviQQApvrh9gaDTcnBFYiCyiykQ0=; b=Z9v4S/xNrZ5+V8KGIjlsUPJ0TQRlXFk4HPewR0SD3t2GuzjCauzBHmMqLDCyyjK5pZ ODV4jcFL6Skn4isU9ki4iVY0ADaCd+/KQX9zu/beIEM3ao153v0ppZnnjvI+YPu4lr1E 6GzZT8dBhqchYqFvSJ2Zl+4Z1GCL0IikfuHdMVGVVEhMqz7HC6UjXYVCAnm6UVew/sa/ t74TrbGhkRoVIxqbQ/iwcIEQQSUhQkG7ZwdGV+3LRP/89RfVCWmuaxLYFbdpU7RncwVQ ceRliu7wmZn56cZ+MtYegOqOKAGJFEvXW69247d+MJdM/Lu+CcVV1qQ33/eaCQhsRY1r CIDQ== X-Gm-Message-State: APt69E2jq5FmVNf7TzqJXC0YjxMmg2g3YuDOPn43M9hiOxq+AH0IubtS j9iJr132eHtKLW+NSD2dHI5XcgoZ2bh6QhcIraEQ9Q== X-Received: by 2002:a24:99c4:: with SMTP id a187-v6mr7337627ite.148.1530868922111; Fri, 06 Jul 2018 02:22:02 -0700 (PDT) MIME-Version: 1.0 References: <1530200714-4504-1-git-send-email-vincent.guittot@linaro.org> <1530200714-4504-8-git-send-email-vincent.guittot@linaro.org> <20180706060033.rcgzfs6pouqssiqh@vireshk-i7> <20180706091429.GJ2494@hirez.programming.kicks-ass.net> In-Reply-To: <20180706091429.GJ2494@hirez.programming.kicks-ass.net> From: Vincent Guittot Date: Fri, 6 Jul 2018 11:21:50 +0200 Message-ID: Subject: Re: [PATCH 07/11] cpufreq/schedutil: take into account interrupt To: Peter Zijlstra Cc: viresh kumar , Ingo Molnar , linux-kernel , "Rafael J. Wysocki" , Juri Lelli , Dietmar Eggemann , Morten Rasmussen , Valentin Schneider , Patrick Bellasi , Joel Fernandes , Daniel Lezcano , Quentin Perret , Luca Abeni , Claudio Scordino , Ingo Molnar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Jul 2018 at 11:14, Peter Zijlstra wrote: > > On Fri, Jul 06, 2018 at 11:30:33AM +0530, Viresh Kumar wrote: > > On 28-06-18, 17:45, Vincent Guittot wrote: > > > The time spent under interrupt can be significant but it is not reflected > > > in the utilization of CPU when deciding to choose an OPP. Now that we have > > > access to this metric, schedutil can take it into account when selecting > > > the OPP for a CPU. > > > rqs utilization don't see the time spend under interrupt context and report > > > their value in the normal context time window. We need to compensate this when > > > adding interrupt utilization > > > > > > The CPU utilization is : > > > irq util_avg + (1 - irq util_avg / max capacity ) * /Sum rq util_avg > > > > > > A test with iperf on hikey (octo arm64) gives: > > > iperf -c server_address -r -t 5 > > > > > > w/o patch w/ patch > > > Tx 276 Mbits/sec 304 Mbits/sec +10% > > > Rx 299 Mbits/sec 328 Mbits/sec +09% > > > > > > 8 iterations > > > stdev is lower than 1% > > > Only WFI idle state is enable (shallowest diel state) > > Also s/diel/idle/ > > > > + /* > > > + * Interrupt time is not seen by rqs utilization nso we can compare > > > > nso ? > > > > > + * them with the CPU capacity > > > + */ > > Already fixed ;-) Thanks