Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1660675imm; Fri, 6 Jul 2018 04:20:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdMe1G4ZnV1SlbNOno6Fjyh5+C23wB9YXOPdvgk/NkqhwZnygt1aPFQKNYk8sLOVg6vr6kf X-Received: by 2002:a62:591a:: with SMTP id n26-v6mr10285859pfb.94.1530876016849; Fri, 06 Jul 2018 04:20:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530876016; cv=none; d=google.com; s=arc-20160816; b=sJUirZyGGcC76p3pDR8AAQhjsugR9EWGc0lTLoMepNHeLb9DIJdNL+rcSB+0Ygasaj foJO/7IVVAYpPbM6jO28BuGSUluE7bFk5fAgljgu2nmM1ZAkQKMeU60KJRgNZff8xQla IpWS0IlqyKeGthQVMqZ4X18vkL+PJYgbZ/F15AcxQ1pTw17+nSHz/Cmvi1d3sLO07Tpq 6M08jNJCucJ39ZsgaVf8QVWSK8nj1M1rbCwxocqjVrl7p6rFH1Cha6fXKZA1xKQGL/C6 PcQ7iMffxsXH/M/WbJEbIhD95wRHtR5XeFqFOOtHskfsIgs05AJWy2m2+9SrptsNcDNG 6oPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=XXsKZqjxZ3koApa5aaJ0ibv6jHh5uHMMgpN8lxqDlG8=; b=o2djX31PY2d3El5YKLgDZc5lPOE7dfDEzgpUo/2g89yUDJLE3Snd3cDfzF1de44Ed4 dhMPg8mNkICMov6cPIVquST4nO9KQ8bPj8yFFIoYUYVXijoxe3iY3SHVwo0LbBGxKeDM 56uW5LIumfmd4z3LaxZBgRIgU74+bn3ak1KM1Nevz7N69SvuNKo6FnBACNH3wIuxtvqv BDzIuw+HZ/eKZ4p9H69vDdnNTCwIS9CoLaG9jXliiBvDUkk2uSxzo7AV19giwZXJjXmq D6QaQ9BMPaXgxvGWb1cjEeTbQbovm5ZC42PU2CqIUsytcMjWsB9XxIB393t/ACE1jgTT D5aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=eoVxEb66; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i23-v6si7758204pgb.246.2018.07.06.04.19.56; Fri, 06 Jul 2018 04:20:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=eoVxEb66; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbeGFLTK (ORCPT + 99 others); Fri, 6 Jul 2018 07:19:10 -0400 Received: from 8bytes.org ([81.169.241.247]:53218 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753708AbeGFLTH (ORCPT ); Fri, 6 Jul 2018 07:19:07 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 5749A2EE; Fri, 6 Jul 2018 13:19:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1530875945; bh=a34WeAziQBG2kuS9VmwfWYmNC0vhx2A8bt5HSkjQpgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eoVxEb66GJAdI4hKVx1XHfesjNmNrm0RG1/d4nqkQbAHTl9jCvKbhqDhZtcKGoqsj RnC/9enacq+iGmC6bHrXpeSXzgiklVMSjcdpGxL5oHOAxN44a1U8fVAOMZlP7qF0MU WWDs+vJ6yvbPyuaaIR+bG3KEXWSF4JsFTNPO821a95ymdMEj3CApgqmSpGbfH4v5Sg QXcEqykOMF0zt+He23FiZmDwuGo2y6/fLr+YHWzZ0g0erVSuKazJjG6zkRwbeBDHS1 zn7L5aXziD8SA2tOaCdOxx+aEDth1KJ3N7jrKf2Hiv36QlrDb6vSxcJLgjAv6VFnSG wpVJEtY9ZFrAw== Date: Fri, 6 Jul 2018 13:18:40 +0200 From: Joerg Roedel To: "yzhai003@ucr.edu" Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, csong@cs.ucr.edu, zhiyunq@cs.ucr.edu Subject: Re: [PATCH] iommu/amd: Argument page_size could be uninitialized Message-ID: <20180706111839.wwgnewib2r6xf4jd@8bytes.org> References: <1527877815-11132-1-git-send-email-yzhai003@ucr.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527877815-11132-1-git-send-email-yzhai003@ucr.edu> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 01, 2018 at 11:30:14AM -0700, yzhai003@ucr.edu wrote: > Argument "page_size" passing to function "fetch_pte" could be > uninitialized if the function returns NULL > > The caller "iommu_unmap_page" checks the return value but the page_size is > used outside the if block. > > Signed-off-by: yzhai003@ucr.edu > --- > drivers/iommu/amd_iommu.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks.