Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jan Glauber <jglauber@cavium.com>
Date:   Fri, 6 Jul 2018 13:42:16 +0200
To:     Kees Cook <keescook@chromium.org>
Cc:     Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC, thunderx: Remove VLA usage
Message-ID: <20180706114216.GA31180@wintermute>
References: <20180629184850.GA37464@beast>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180629184850.GA37464@beast>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 29, 2018 at 11:48:50AM -0700, Kees Cook wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> switches to using a kmalloc-allocated buffer instead of stack space.
> This should be fine since the existing routine is allocating memory
> too.
> 
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> 
> Cc: David Daney <david.daney@cavium.com>
> Cc: Jan Glauber <jglauber@cavium.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-edac@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Jan Glauber <jglauber@cavium.com>

thanks,
Jan

> ---
>  drivers/edac/thunderx_edac.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 4803c6468bab..c009d94f40c5 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -408,26 +408,29 @@ static ssize_t thunderx_lmc_inject_ecc_write(struct file *file,
>  					     size_t count, loff_t *ppos)
>  {
>  	struct thunderx_lmc *lmc = file->private_data;
> -
>  	unsigned int cline_size = cache_line_size();
> -
> -	u8 tmp[cline_size];
> +	u8 *tmp;
>  	void __iomem *addr;
>  	unsigned int offs, timeout = 100000;
>  
>  	atomic_set(&lmc->ecc_int, 0);
>  
>  	lmc->mem = alloc_pages_node(lmc->node, GFP_KERNEL, 0);
> -
>  	if (!lmc->mem)
>  		return -ENOMEM;
>  
> +	tmp = kmalloc(cline_size, GFP_KERNEL);
> +	if (!tmp) {
> +		__free_pages(lmc->mem, 0);
> +		return -ENOMEM;
> +	}
> +
>  	addr = page_address(lmc->mem);
>  
>  	while (!atomic_read(&lmc->ecc_int) && timeout--) {
>  		stop_machine(inject_ecc_fn, lmc, NULL);
>  
> -		for (offs = 0; offs < PAGE_SIZE; offs += sizeof(tmp)) {
> +		for (offs = 0; offs < PAGE_SIZE; offs += cline_size) {
>  			/*
>  			 * Do a load from the previously rigged location
>  			 * This should generate an error interrupt.
> @@ -437,6 +440,7 @@ static ssize_t thunderx_lmc_inject_ecc_write(struct file *file,
>  		}
>  	}
>  
> +	kfree(tmp);
>  	__free_pages(lmc->mem, 0);
>  
>  	return count;
> -- 
> 2.17.1
> 
> 
> -- 
> Kees Cook
> Pixel Security