Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1700676imm; Fri, 6 Jul 2018 05:05:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdjCEMeGm1pHSMsH8gYVC+fgF2qOP0rf4o5ojvm+XpYbIzGUKHwJdhGxqtNawElp6How969 X-Received: by 2002:a63:4283:: with SMTP id p125-v6mr9383903pga.142.1530878755249; Fri, 06 Jul 2018 05:05:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530878755; cv=none; d=google.com; s=arc-20160816; b=J7ZTFBw1foyIj5ZynPpbBz+pvZspCjZXZK8QO2vbvwA7NROv7BhFehCDa7jK/VYxNS 7au9evmacd59fioYRiDZu0EVQ4Jm4pS/1cn/DgRMcyrUvkxqq+XD2nRrABhHOtA5DvSw r+a9+GA1OgBn9F/e7xlw3rCW2T2Ef+cmnljKYorS7NFK6JT35Bm42QZN03NONWfYE0NB bEutGoszZ7q8mcQTK89AztewNcL23fQ/FoEjQjJpFzyMhW+SYlG9MLZVq5e18cgbkC3b wurYbsbUF5s4frpJke+0+31CMf+c9QYPsx07ViBExMGL8rpP5zHYzRqtepc1BJXn8I+1 SG0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=a8JkuYbKoduJcFYTfsR7uyoQ/88o5G8M4Dv2UggnxeQ=; b=r0W/nzAqlEGl02c2a6pRtilVpJrlJ6M97kKefe0FsGtr2tPjW21B9ggmEkzKrVupi7 xF0nXBZtRVnRFiPxKFcr0fKeumDih3no+m8Vb72aI+9FL8Y/HkKCAhW8an8LncGwPflj g3845pMKwFS8RGUHYfF36lbiDg0qgFVsNrdW+/5ZoKiRV2G5K030TK0QfXRjXrv5YVs4 0yCjCFhLENmJbkQ93UuiUwUXndrJRK/8SRph71EYAIXQz5kqrtwuZcUK2KUUOZYsZMOs PBQLPiNuq6Q1hi0dhRWKSXuw2p9Dk4LA7UsBu4JAfITDmw6xKzEHzPCDj3rxR+nK2M/w w52g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27-v6si7880733pgn.24.2018.07.06.05.05.39; Fri, 06 Jul 2018 05:05:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709AbeGFMEv (ORCPT + 99 others); Fri, 6 Jul 2018 08:04:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753652AbeGFMEu (ORCPT ); Fri, 6 Jul 2018 08:04:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 41A77407446D; Fri, 6 Jul 2018 12:04:50 +0000 (UTC) Received: from [10.72.12.18] (ovpn-12-18.pek2.redhat.com [10.72.12.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB50D2026D68; Fri, 6 Jul 2018 12:04:44 +0000 (UTC) Subject: Re: [PATCH v3 0/3] uio: fix potential crash bug To: Hamish Martin , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" Cc: "jannh@google.com" , "pkalever@redhat.com" , "pkarampu@redhat.com" , "atumball@redhat.com" , "sabose@redhat.com" , "mchristi@redhat.com" References: <1530845836-49101-1-git-send-email-xiubli@redhat.com> <0002b0fb-4612-b371-d929-bf64aa877225@alliedtelesis.co.nz> From: Xiubo Li Message-ID: <060d9f68-6d73-a38a-98a5-b0670ee18907@redhat.com> Date: Fri, 6 Jul 2018 20:04:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <0002b0fb-4612-b371-d929-bf64aa877225@alliedtelesis.co.nz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 06 Jul 2018 12:04:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 06 Jul 2018 12:04:50 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'xiubli@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/7/6 11:31, Hamish Martin wrote: > Hi Xiubo, > > Thanks for your patch that addresses the regression found with my > earlier commit. > > I will take your code and run it in our scenario that showed the bug > that led to my commit. Unfortunately I won't be able to get that done > until mid-next week. I intend to report back to you by July 13th. Hi Hamish, Thanks verrrry much for your quickly review and reply about this. Take your time :-) BRs Xiubo > Thanks, > Hamish M > > On 07/06/2018 02:57 PM, xiubli@redhat.com wrote: >> From: Xiubo Li >> >> The V2 patch set maybe not post successfully, so post it again >> with one new updation. >> >> V2: >> - resend it with some small fix >> >> V3: >> - switch to use request_threaded_irq >> >> >> Xiubo Li (3): >> uio: use request_threaded_irq instead >> uio: change to use the mutex lock instead of the spin lock >> uio: fix crash after the device is unregistered >> >> drivers/uio/uio.c | 151 ++++++++++++++++++++++++++++++++++----------- >> include/linux/uio_driver.h | 2 +- >> 2 files changed, 115 insertions(+), 38 deletions(-) >>