Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1730179imm; Fri, 6 Jul 2018 05:36:08 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf4Xiwu/9UMtH2UDfTQXrk2BVtIyc8ntr4jxmxQYuDNvKIipxojrAHjfEqWoReThKMSuc8f X-Received: by 2002:aa7:8298:: with SMTP id s24-v6mr10427077pfm.136.1530880568866; Fri, 06 Jul 2018 05:36:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530880568; cv=none; d=google.com; s=arc-20160816; b=bZbZh72n0hGvupB3K0IODXAphN7Ey77Wi+aWhuZxKrxpNVxGxuAFOTZG80raMOuKS4 2lKIejBH/UST14sSPkvo/wWiPehVJy/zYqPu4LGOGRelBijpfQP1Y5QYl2nPDcvlMk8a QVfYQ+AH/UWSymUb+k/psL8tiQo/+fQTTih2DGVRYOj7/fBvpBLaYAdjSioB0o64YHOi jOSSsNUZJnhs+iIU8J7gVuL8IGcgSoaovEPGOrNwBhyCjschCoZHrEBWkvsYfYF/gq77 gTnvryv9KHe3udhOp+fUEWy+VGZ4Kb2feOZFXpmtr4fivTeipMBxTQvqDfl3VBtufbvg BkOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=DeoCbXSlKL/GBoRMiYwZECTNd0zF8IJFC4wjaqqdPB4=; b=AikvQLreHb0pzjpSaTssj5pWwnoUPNVWXgV0JayFv2aVyCDo2/73TSnIrWBvj/rUyE ObPsUo6nAQnU58SnQUqfGrdocAYzAU3i5U02cwoHSxy5sEBxusWHkgIy/xG9lfyLBU2N /l2xbx3UfnjAmPFV2SbZEWWzCO3aZwv0yiYKmm4V00hWORdyfPAU5WOZp5D1GqeaEP45 /uXvjNC1tLY/r6C4zSSi7o7OjftMZjXedddydGGAj0EV69xBO978AK7NnHDP/NAeNRwZ ktzvFe0WxLIhNo9SOTQ3WtGV605qwIwtIrjgWPNS03IAV9jQFQFISOoZkkMQYgm01JV1 tToA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q67-v6si7590995pga.63.2018.07.06.05.35.52; Fri, 06 Jul 2018 05:36:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932962AbeGFMdm (ORCPT + 99 others); Fri, 6 Jul 2018 08:33:42 -0400 Received: from bran.ispras.ru ([83.149.199.196]:21717 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932648AbeGFMdl (ORCPT ); Fri, 6 Jul 2018 08:33:41 -0400 Received: from myklebust.intra.ispras.ru (unknown [10.10.2.207]) by smtp.ispras.ru (Postfix) with ESMTP id B3241203C8; Fri, 6 Jul 2018 15:33:39 +0300 (MSK) From: Anton Vasilyev To: Greg Kroah-Hartman Cc: Anton Vasilyev , Andrey Konovalov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] uwb: hwa-rc: fix memory leak at probe Date: Fri, 6 Jul 2018 15:32:53 +0300 Message-Id: <20180706123253.15570-1-vasilyev@ispras.ru> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hwarc_probe() allocates memory for hwarc, but does not free it if uwb_rc_add() or hwarc_get_version() fail. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- drivers/uwb/hwa-rc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/uwb/hwa-rc.c b/drivers/uwb/hwa-rc.c index 9a53912bdfe9..5d3ba747ae17 100644 --- a/drivers/uwb/hwa-rc.c +++ b/drivers/uwb/hwa-rc.c @@ -873,6 +873,7 @@ static int hwarc_probe(struct usb_interface *iface, error_rc_add: usb_put_intf(iface); usb_put_dev(hwarc->usb_dev); + kfree(hwarc); error_alloc: uwb_rc_put(uwb_rc); error_rc_alloc: -- 2.18.0