Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 6 Jul 2018 15:00:24 +0200
From:   Joerg Roedel <joro@8bytes.org>
To:     Joe Perches <joe@perches.com>
Cc:     Walter Harms <wharms@bfs.de>, "Hook, Gary" <ghook@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: fix missing tag from dev_err message
Message-ID: <20180706130024.GD13903@8bytes.org>
References: <1540588259.84011.1530637026831@ox-groupware.bfs.de>
 <cb5702b95b8d4914612526125f625c4bc2cedfcc.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cb5702b95b8d4914612526125f625c4bc2cedfcc.camel@perches.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 03, 2018 at 10:34:12AM -0700, Joe Perches wrote:
> On Tue, 2018-07-03 at 18:57 +0200, Walter Harms wrote:
> > It is only cosmetics but even the author got lost about the loose bracket.
> > I would suggest to remove all the brackets or if needed to move the [ in the
> > message. We have enought memory this days.
> 
> My suggestion would be to remove the separate dev_err
> and use "Event log [" in each dev_err.
> 
> So here's an actual suggested patch that does a few things:
> 
> o Coalesce formats and realigns arguments
> o Uses pr_fmt and dev_fmt to prefix "AMD-Vi: " to all messages
> o Remove embedded "AMD-Vi: " from various formats

Nice cleanup! But I got lost a bit in the patches floating around in
this thread and their dependencies. Can someone sort it out and send it
a new patch-set to me?


Thanks,

	Joerg