Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1864175imm; Fri, 6 Jul 2018 07:51:47 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdcswYDcjDAe22mKzfWau9Y8Fcjn9EMfl8ru8qzW7mkavTrX55vXOADmhLpyNMNWMXJiSLZ X-Received: by 2002:aa7:8645:: with SMTP id a5-v6mr10820568pfo.247.1530888707717; Fri, 06 Jul 2018 07:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530888707; cv=none; d=google.com; s=arc-20160816; b=Oo9SA9GgmG3RqatL46fI3bvPkYxkEPdficLP9VJUQoappvQfw1QQsIv1nSjAqYom+f eCLns1MRbTjgEDXRa9LErj4Xlrd4R45IAO5mkTwAL32vo/lZq2RWhU1TzmWvBdOJKzrs /89nRJjDnzud7/e+rqJvc42/oJBq4y4oW3yIU3tjJzvLsyITU8G+S4wiJKz8HZuJdaRX EHYBq7ILNXhzcwdm3ZXTuVvptkYVMvoP0cK4n8pcBPVYUeNX7DCq4ZbMghf2mVy3w2iK 0Cc56ZgEEd/Aq9PoooEdcotrojcM6mTTaKRp3hUEooV9raZlDyQ88LMQxiDkjm8dQlp+ Ov7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=s+O6ggKE+IMyOTdXhhOWVCklGeLGIgFsEN9oKfbXhJI=; b=WxdjQqogm12xjcNWAYAxkYbl04o2iA/KoaMdQS0mdeBvVqVqutS3xxtl+zhOrw83Zb sor88bnW1fD3wv4chnCo4FF7MTeWMwTH6I4eQaG+f5F4J40+obRvycBrWaO1tTlV5qqL hZMyO4d6qbqzhA3SLFCPaLlfLq5T4iCKlqbOECfEBPiyH1YawueGpNstsU4rIQ2+d1ei gnvtuPl1pwwHfWbRZ5/SJNirTf3IoLgydCKyiHd5issf+QmgTpvOU3RJMm1AG9/dT9xC fseEHY6qVxsGx4pYSBDLXXLHf4fBpIE7+9PbvvUn80Idzc++m6cUtiPOby2ZB+XOR3iO KqkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t17-v6si8462532pfa.170.2018.07.06.07.51.32; Fri, 06 Jul 2018 07:51:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932893AbeGFOt7 (ORCPT + 99 others); Fri, 6 Jul 2018 10:49:59 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:33086 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932769AbeGFOt5 (ORCPT ); Fri, 6 Jul 2018 10:49:57 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id A48A56093339; Fri, 6 Jul 2018 16:49:56 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vI2EM7P2lhBT; Fri, 6 Jul 2018 16:49:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 69973609333C; Fri, 6 Jul 2018 16:49:56 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mG7xLm8TB4Va; Fri, 6 Jul 2018 16:49:56 +0200 (CEST) Received: from blindfold.localnet (213-47-184-186.cable.dynamic.surfer.at [213.47.184.186]) by lithops.sigma-star.at (Postfix) with ESMTPSA id 437396093339; Fri, 6 Jul 2018 16:49:56 +0200 (CEST) From: Richard Weinberger To: Boris Brezillon Cc: Benjamin Gaignard , marek.vasut@gmail.com, dwmw2@infradead.org, computersforpeace@gmail.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Benjamin Gaignard Subject: Re: [PATCH] mtd: stm32-quadspi: replace "%p" with "%pK" Date: Fri, 06 Jul 2018 16:49:55 +0200 Message-ID: <1574993.BxlVuaNddV@blindfold> In-Reply-To: <20180706164732.5776df5a@bbrezillon> References: <20180706130525.22223-1-benjamin.gaignard@st.com> <32602293.7BQn8HeLUA@blindfold> <20180706164732.5776df5a@bbrezillon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 6. Juli 2018, 16:47:32 CEST schrieb Boris Brezillon: > On Fri, 06 Jul 2018 16:44:44 +0200 > Richard Weinberger wrote: > > > Am Freitag, 6. Juli 2018, 15:05:25 CEST schrieb Benjamin Gaignard: > > > The format specifier "%p" can leak kernel addresses. > > > Use "%pK" instead. > > > > Does %pK really make sense for dev_dbg()? > > When the driver is being debugged "leaking" is on purpose. :) > > %p already gives you a hash of the pointer address. At least with %pK > you can turn it off through a sysctl :). Once again I mixed %p and %pK. So then %pK is what we want. :D Thanks, //richard