Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates
 208.19.100.21 as permitted sender) receiver=protection.outlook.com;
 client-ip=208.19.100.21; helo=AVMBX1.microsemi.net;
From:   Dave Carroll <david.carroll@microsemi.com>
To:     Johannes Thumshirn <jthumshirn@suse.de>
CC:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        "Linux Kernel Mailinglist" <linux-kernel@vger.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
        Raghava Aditya Renukunta 
        <RaghavaAditya.Renukunta@microsemi.com>
Subject: RE: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define
Thread-Topic: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define
Thread-Index: AQHUFE+SkQv4rrPc10uDGWlD5Wf3BKSA5dDwgAFmboCAAB3lgA==
Date:   Fri, 6 Jul 2018 16:55:26 +0000
Message-ID: <a5821f3718a44782a41779fea7e0f6ed@microsemi.com>
References: <20180705110140.19545-1-jthumshirn@suse.de>
 <20180705110140.19545-2-jthumshirn@suse.de>
 <4cd9a8cb64dc4d8aa1e10c3b008c3ba0@microsemi.com>
 <20180706080301.gvjxdd4w5eun2x2h@linux-x5ow.site>
In-Reply-To: <20180706080301.gvjxdd4w5eun2x2h@linux-x5ow.site>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 16:55:48.3273
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ae0b4511-5aae-4513-e07d-08d5e36152d3
X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.21];Helo=[AVMBX1.microsemi.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3348
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> On Thu, Jul 05, 2018 at 05:42:02PM +0000, Dave Carroll wrote:
> > > Remove the AAC_STAT_GOOD definition and open code it in the places
> > > it was used.
> > >
> > > This will make subsequent refactoring in this area easier.
> > >
> > Please don't ... the definition itself was added to make refactoring ea=
sier.
>=20
> Well in the end scsi_cmnd::result as we know it currently will go away, s=
o
> splitting up the define is rather crucial for this. I could do it when ch=
anging the -
> >result from one integer into 4 u8s but doing it in a separate preparatio=
n step
> would be preferable to me and it doesn't hurt accraid at all.
>=20

Thanks for the explanation Johannes, the routine is unwieldy already, and i=
t just=20
didn't feel right adding back all those lines ... Looking forward to the ne=
xt step ...

Reviewed-by: Dave Carroll <david.carroll@microsemi.com>