Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 3/3] uio: fix crash after the device is unregistered
To:     xiubli@redhat.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
References: <1530845836-49101-1-git-send-email-xiubli@redhat.com>
 <1530845836-49101-4-git-send-email-xiubli@redhat.com>
Cc:     hamish.martin@alliedtelesis.co.nz, jannh@google.com,
        pkalever@redhat.com, pkarampu@redhat.com, atumball@redhat.com,
        sabose@redhat.com
From:   Mike Christie <mchristi@redhat.com>
Message-ID: <5B3FB3B0.7010105@redhat.com>
Date:   Fri, 6 Jul 2018 13:23:44 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1530845836-49101-4-git-send-email-xiubli@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/05/2018 09:57 PM, xiubli@redhat.com wrote:
>  static irqreturn_t uio_interrupt(int irq, void *dev_id)
>  {
>  	struct uio_device *idev = (struct uio_device *)dev_id;
> -	irqreturn_t ret = idev->info->handler(irq, idev->info);
> +	irqreturn_t ret;
> +
> +	mutex_lock(&idev->info_lock);
> +	if (!idev->info) {
> +		ret = IRQ_NONE;
> +		goto out;
> +	}
>  
> +	ret = idev->info->handler(irq, idev->info);
>  	if (ret == IRQ_HANDLED)
>  		uio_event_notify(idev->info);
>  
> +out:
> +	mutex_unlock(&idev->info_lock);
>  	return ret;
>  }


Do you need the interrupt related changes in this patch and the first
one? When we do uio_unregister_device -> free_irq does free_irq return
when there are no longer running interrupt handlers that we requested?

If that is not the case then I think we can hit a similar bug. We do:

__uio_register_device -> device_register -> device's refcount goes to
zero so we do -> uio_device_release -> kfree(idev)

and if it is possible the interrupt handler could still run after
free_irq then we would end up doing:

uio_interrupt -> mutex_lock(&idev->info_lock) -> idev access freed memory.