Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 6 Jul 2018 14:29:42 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Jakub Kicinski <jakub.kicinski@netronome.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>,
        Quentin Monnet <quentin.monnet@netronome.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH v2 bpf-next 3/3] bpftool: add bash completion for cgroup
 tree command
Message-ID: <20180706212939.GA3582@castle.DHCP.thefacebook.com>
References: <20180706183012.6475-1-guro@fb.com>
 <20180706183012.6475-3-guro@fb.com>
 <20180706135805.1d90ff33@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20180706135805.1d90ff33@cakuba.netronome.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 21:29:47.8527 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ab990047-e4b6-4f04-a723-08d5e38799e4
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR15MB0172
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-06_06:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 06, 2018 at 01:58:05PM -0700, Jakub Kicinski wrote:
> On Fri, 6 Jul 2018 11:30:12 -0700, Roman Gushchin wrote:
> > This commit adds a bash completion to the bpftool cgroup tree
> > command.
> > 
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Cc: Quentin Monnet <quentin.monnet@netronome.com>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > ---
> >  tools/bpf/bpftool/bash-completion/bpftool | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> > index fffd76f4998b..82681eb9c02a 100644
> > --- a/tools/bpf/bpftool/bash-completion/bpftool
> > +++ b/tools/bpf/bpftool/bash-completion/bpftool
> > @@ -414,6 +414,9 @@ _bpftool()
> >                      _filedir
> >                      return 0
> >                      ;;
> > +		tree)
> > +		    _filedir
> > +		    return 0
> 
> Oh you have not tested this at all, have you?
> 
> You're missing ;; at the end of the case, this is not correct bash
> syntax and completely breaks the script.
> 
> When you respin please use spaces instead of tabs (I know, *very*
> annoying but that's apparently how things should be for bash
> completions :/).
> 
> And please add "tree" to the *) case which completes the actions.

Sorry, thought it's simple enough for a copy-paste, but no :)
Fixed in v3.

Thanks!