Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5ebb181efcdd2cdb3c1ee8eac9bba26f5759a0ea.camel@perches.com>
Subject: Re: [PATCH] get_maintainer.pl: Add optional
 .get_maintainer.MAINTAINERS override
From:   Joe Perches <joe@perches.com>
To:     Don Zickus <dzickus@redhat.com>
Cc:     Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org,
        jtoppins@redhat.com
Date:   Fri, 06 Jul 2018 15:09:17 -0700
In-Reply-To: <20180706215851.sqpibusyqukbh55g@redhat.com>
References: <20180626182505.4176-1-prarit@redhat.com>
         <601f0e6bf3baa88b9f6145e635d728a435542292.camel@perches.com>
         <20180706175419.6irtvs64e6dbz7hk@redhat.com>
         <c187fe5040cb616292dab6c106352273df95bc41.camel@perches.com>
         <20180706184411.ilzbt7fxuje2nhx6@redhat.com>
         <716eb88d-31ac-c488-f799-dec9c9afb5af@redhat.com>
         <948af2d06623e8fcca6f0c0fd300a65bbfd1c6fa.camel@perches.com>
         <20180706215851.sqpibusyqukbh55g@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-07-06 at 17:58 -0400, Don Zickus wrote:
> On Fri, Jul 06, 2018 at 02:36:28PM -0700, Joe Perches wrote:
> > > > > > Just trying to find ways to minimize our collection of private patches.
> > > > > 
> > > > > Perhaps that could be extended for your purpose
> > > > > with some additional argument like a specific
> > > > > optional directory/path where every subdirectory
> > > > > would be found.
> > > > 
> > > > So something like --find-maintainer-files=<dir> ?  I think that could work.
> > > 
> > > So --find-maintainers-files=./kernel/pci
> > > 
> > > would only look for MAINTAINERS files under kernel/pci?
> > 
> > Well, perhaps yes.   Perhaps it would also read
> > a top level MAINTAINERS file.  Dunno.  What seems
> > right to you?
> > 
> > I don't have an objection to
> > --find-maintainer-files=<path_or_file> where
> > the existing behavior of --find-maintainer-files
> > without <path_or_file> is all subdirs.
> > 
> > Perhaps something like the below
> > (some of this is whitespace change only)
> > ---
> >  scripts/get_maintainer.pl | 40 ++++++++++++++++++++++------------------
> >  1 file changed, 22 insertions(+), 18 deletions(-)
> > 
> 
> <snip>
> 
> > +
> > +    if (defined $find_maintainer_files) {
> > +	die "$P: invalid find-maintainer-files <$path>" if (!-d $path);
> 
> ^^^^^
> 
> Hi Joe,
> 
> Thanks for the patch!!  If I remove the above 'die' line I can pass in a
> file or a dir.  Otherwise the 'die' line prevents a 'file' from being used.

Change it to (!-e $file), I was just spitballing.

> Not sure if that is important for this patch or not.

It's not.

> We have an internal use case of multiple MAINTAINER files, some folks have
> more rights to patches than others so they are not allowed to be cc'd (think
> embargoed stuff).
> 
> So the 'file' usage would be useful for us.   But if you are against it, we can
> easily patch it out on our end.

cheers, Joe