Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/4] iommu/vt-d: Clean up pasid quirk for pre-production
 devices
To:     Chris Wilson <chris@chris-wilson.co.uk>,
        David Woodhouse <dwmw2@infradead.org>,
        Joerg Roedel <joro@8bytes.org>
References: <1525410499-18632-1-git-send-email-baolu.lu@linux.intel.com>
 <1525410499-18632-4-git-send-email-baolu.lu@linux.intel.com>
 <153094688126.17577.10340360451966114779@cwilso3-mobl.ger.corp.intel.com>
Cc:     ashok.raj@intel.com, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org,
        "Balestrieri, Francesco" <francesco.balestrieri@intel.com>
From:   Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <5B4069F5.1020303@linux.intel.com>
Date:   Sat, 7 Jul 2018 15:21:25 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <153094688126.17577.10340360451966114779@cwilso3-mobl.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Chris,

On 07/07/2018 03:01 PM, Chris Wilson wrote:
> Quoting Lu Baolu (2018-05-04 06:08:18)
>> The pasid28 quirk is needed only for some pre-production devices.
>> Remove it to make the code concise.
> Every skylake mixing iommu and i915 is now inoperable on boot. Reads
> by the GPU from iommu map pages return zero, writes disappear into the
> void, no errors flagged.
>
> Please revert until the matter is resolved.

Yes. I also got reports about the i915 issue.

I will submit a revert patch as soon as possible.

I am sorry for the inconvenience.

Best regards,
Lu Baolu