Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 07 Jul 2018 20:05:26 +0900 (KST)
Message-Id: <20180707.200526.1062008433639194322.davem@davemloft.net>
To:     arnd@arndb.de
Cc:     nikolay@cumulusnetworks.com, jiri@mellanox.com,
        yotamg@mellanox.com, roopa@cumulusnetworks.com, petrm@mellanox.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: fix br_vlan_get_{pvid,info} return
 values
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180706124420.3129099-1-arnd@arndb.de>
References: <20180706124420.3129099-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri,  6 Jul 2018 14:44:02 +0200

> These two functions return the regular -EINVAL failure in the normal
> code path, but return a nonstandard '-1' error otherwise, which gets
> interpreted as -EPERM.
> 
> Let's change it to -EINVAL for the dummy functions as well.
> 
> Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks Arnd.